Feat screenshot html #1226
Merged
Feat screenshot html #1226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ehsandeep
added
the
Type: Enhancement
|
Populated response info column with the flags provided by user review please |
Mzack9999
requested changes
Jun 15, 2023
There was a problem hiding this comment.
@bugrakocabay This is a very cool feature! What do you think about moving the html code into an external html template that can be populated with template syntax (either go native or something like twig like syntax)? In this way the output report would be completely customizable
|
Spinned up a new goroutine with a channel, as when I used it inside the one above it, some race conditions occurred. |
ehsandeep
approved these changes
Jul 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As requested here, I have implemented a feature for -screenshot flag, which saves the result screenshots in an indexed html file as this;
The basic functionality is ready, but there is still room for improvement. Open for any suggestions.