Fix Static Analysis Issues for Sensor Module for IVI

sensors/2.0/iiohal_mediation_v2.0/Sensor.cpp

@@ -104,7 +104,7 @@ Result Sensor::flush() {
     // Note: If a sensor supports batching, write all of the
     // currently batched events for the sensor to the Event
     // FMQ prior to writing the flush complete event.
-    Event ev;
+    Event ev{};
     ev.sensorHandle = mSensorInfo.sensorHandle;
     ev.sensorType = SensorType::META_DATA;
     ev.u.meta.what = MetaDataEventType::META_DATA_FLUSH_COMPLETE;

sensors/2.0/iiohal_mediation_v2.0/Sensors.h

@@ -101,7 +101,7 @@ struct Sensors : public ISensorsInterface, public ISensorsEventCallback {
 	if(mSensors.size() <= 0) {
             return Result::BAD_VALUE;
         }
-        for (auto sensor : mSensors) {
+        for (auto& sensor : mSensors) {
             sensor.second->setOperationMode(mode);
         }
         return Result::OK;
@@ -134,7 +134,7 @@ struct Sensors : public ISensorsInterface, public ISensorsEventCallback {
         Result result = Result::OK;
 
         // Ensure that all sensors are disabled
-        for (auto sensor : mSensors) {
+        for (auto& sensor : mSensors) {
             sensor.second->activate(false /* enable */);
         }
 
@@ -247,9 +247,11 @@ struct Sensors : public ISensorsInterface, public ISensorsEventCallback {
      * Utility function to delete the Event Flag
      */
     void deleteEventFlag() {
-        status_t status = EventFlag::deleteEventFlag(&mEventQueueFlag);
-        if (status != OK) {
-            ALOGI("Failed to delete event flag: %d", status);
+        if (mEventQueueFlag != nullptr) {
+            status_t status = EventFlag::deleteEventFlag(&mEventQueueFlag);
+            if (status != OK) {
+                ALOGI("Failed to delete event flag: %d", status);
+            }
         }
     }
 

sensors/2.0/iiohal_mediation_v2.0/iioClient.cpp

@@ -67,12 +67,16 @@ void iioClient::iioThread(struct iioclient_device *devlist) {
      * once before use
      */
     iioClient *iioc = iioClient::get_iioClient();
+
+    if (iioc == NULL)
+        return;
+
     while (!iioc->is_iioc_initialized && !iioc->iioInit())
         sleep(5);
 
     /* post initialization of iio-devices to align with
      * android sensor fwk.*/
-    for (int id = 1; id <= MAX_SENSOR; id++) {
+    for (int id = 1; id < MAX_SENSOR; id++) {
         if (!devlist[id].is_initialized)
             continue;
 
@@ -88,7 +92,7 @@ void iioClient::iioThread(struct iioclient_device *devlist) {
      * this api is implemented to collect active sensor data from iiod.
      */
     while (iioc) {
-        for (int id = 1; id <= MAX_SENSOR; id++) {
+        for (int id = 1; id < MAX_SENSOR; id++) {
             if (!(devlist[id].is_initialized && devlist[id].is_enabled))
                 continue;
 
@@ -238,7 +242,7 @@ bool iioClient::iioInit(void) {
  * enabled set to 1 to enable, or 0 to disable the sensor.
  */
 int iioClient::activate(int handle, bool enabled) {
-    if ((handle < 0) || (handle > MAX_SENSOR)) {
+    if ((handle < 0) || (handle >= MAX_SENSOR)) {
         ALOGE("ERROR: activate(%d) Sensor hadle(%d) is out of range", enabled, handle);
         return 0;
     }
@@ -253,7 +257,7 @@ int iioClient::activate(int handle, bool enabled) {
         return 0;
 
     active_sensor_count = 0;
-    for (int id = 1; id <= MAX_SENSOR; id++)
+    for (int id = 1; id < MAX_SENSOR; id++)
         if (devlist[id].is_initialized && devlist[id].is_enabled)
             active_sensor_count++;
 
@@ -265,6 +269,9 @@ int iioClient::activate(int handle, bool enabled) {
         const struct iio_device *device = devlist[handle].dev;
         struct iio_channel *channel = iio_device_get_channel(device, index);
 
+    if(channel == NULL)
+            continue;
+
         /* skip output channels */
         if (iio_channel_is_output(channel))
             continue;
@@ -287,7 +294,7 @@ int iioClient::activate(int handle, bool enabled) {
  * activated.
  */
 int iioClient::batch(int handle, int32_t sampling_period_ns) {
-    if ((handle < 0) || (handle > MAX_SENSOR)) {
+    if ((handle < 0) || (handle >= MAX_SENSOR)) {
         ALOGE("Warning: batch invalid handle sampling_time(%d) sensor hadle(%d) is out of range",
               sampling_period_ns, handle);
         return 0;

sensors/2.0/iiohal_mediation_v2.0/iioClient.h

@@ -75,6 +75,7 @@ class iioClient {
      */
     iioClient() {
         sensorCount = 0;
+        active_sensor_count = 0;
         ctx = NULL;
         is_iioc_initialized = false;
         static std::thread thread_object(iioThread, devlist);
@@ -102,7 +103,7 @@ class iioClient {
     bool is_iioc_initialized;
     int active_sensor_count;
     struct iio_context *ctx;
-    struct iioclient_device devlist[MAX_SENSOR];
+    struct iioclient_device devlist[MAX_SENSOR]{};
 
     /* member funcions*/
     static void iioThread(struct iioclient_device *devlist);

sensors/2.0/iiohal_mediation_v2.0/libiio_client/device.c

@@ -943,10 +943,6 @@ static int read_each_attr(struct iio_device *dev, enum iio_attr_type type,
             ret = (int) iio_device_buffer_attr_read(dev,
                     NULL, buf, 0x100000);
             break;
-        default:
-            ret = -EINVAL;
-            count = 0;
-            break;
     }
 
     if (ret < 0)
@@ -1035,9 +1031,6 @@ static int write_each_attr(struct iio_device *dev, enum iio_attr_type type,
         case IIO_ATTR_TYPE_BUFFER:
             count = iio_device_get_buffer_attrs_count(dev);
             break;
-        default:
-            ret = -EINVAL;
-            goto err_free_buf;
     }
 
     for (i = 0; i < count; i++) {
@@ -1053,9 +1046,6 @@ static int write_each_attr(struct iio_device *dev, enum iio_attr_type type,
             case IIO_ATTR_TYPE_BUFFER:
                 attr = iio_device_get_buffer_attr(dev, i);
                 break;
-            default:
-                attr = NULL;
-                break;
         }
 
         ret = (int) cb(dev, attr, ptr + 4, len - 4, data);
@@ -1087,9 +1077,6 @@ static int write_each_attr(struct iio_device *dev, enum iio_attr_type type,
             ret = (int) iio_device_buffer_attr_write_raw(dev,
                     NULL, buf, ptr - buf);
             break;
-        default:
-            ret = -EINVAL;
-            break;
     }
 
 err_free_buf:

sensors/2.0/iiohal_mediation_v2.0/libiio_client/iiod-client.c

@@ -38,7 +38,8 @@ static ssize_t iiod_client_read_integer(struct iiod_client *client,
         void *desc, int *val)
 {
     unsigned int i;
-    char buf[1024], *ptr = NULL, *end;
+    char  *ptr = NULL, *end;
+    char buf[1024] = "";
     ssize_t ret;
     int value;
 
@@ -187,7 +188,8 @@ int iiod_client_get_version(struct iiod_client *client, void *desc,
 {
     struct iio_context_pdata *pdata = client->pdata;
     const struct iiod_client_ops *ops = client->ops;
-    char buf[256], *ptr = buf, *end;
+    char buf[256] = "";
+    char *ptr = buf, *end;
     long maj, min;
     int ret;
 
@@ -266,6 +268,9 @@ int iiod_client_get_trigger(struct iiod_client *client, void *desc,
     for (i = 0; i < nb_devices; i++) {
         struct iio_device *cur = iio_context_get_device(ctx, i);
 
+        if (cur == NULL)
+            continue;
+
         if (iio_device_is_trigger(cur)) {
             const char *name = iio_device_get_name(cur);
 
@@ -543,8 +548,10 @@ struct iio_context * iiod_client_create_context(
         goto out_free_xml;
 
     ctx = iio_create_xml_context_mem(xml, xml_len);
-    if (!ctx)
+    if (!ctx) {
         ret = -errno;
+        goto out_free_xml;
+    }
     if (client_id >= 0)
         ctx->client_id = client_id;
 

sensors/2.0/iiohal_mediation_v2.0/libiio_client/network.c

@@ -472,6 +472,7 @@ static int discover_host(AvahiAddress *addr, uint16_t *port)
 }
 #endif /* HAVE_AVAHI */
 
+// coverity[ -taint_source : arg-1 ]
 static ssize_t network_recv(struct iio_network_io_context *io_ctx,
         void *data, size_t len, int flags)
 {
@@ -482,7 +483,6 @@ static ssize_t network_recv(struct iio_network_io_context *io_ctx,
         ret = wait_cancellable(io_ctx, true);
         if (ret < 0)
             return ret;
-
         ret = recv(io_ctx->fd, data, (int) len, flags);
         if (ret == 0)
             return -EPIPE;