feat: move the tenant system namespace inside the tenant #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxgio92
commented
Jan 24, 2024
| @@ -90,7 +90,7 @@ var _ = Describe("Creating a new ServiceAccount", func() { | |||
| }) | |||
| }) | |||
| Context("set as owner of the Tenant", func() { | |||
| BeforeEach(func() { | |||
| BeforeAll(func() { | |||
There was a problem hiding this comment.
Now that the Tenant system NS is part of the Tenant, every time the Tenant is deleted also the system NS is going to be. Repeting creation and deletion of Tenant for every spec is not good and also, not needed.
maxgio92
commented
Jan 24, 2024
maxgio92
force-pushed
the
issue/3
branch
2 times, most recently
from
bd487c9
to
7206185
Compare
maxgio92
changed the title
|
Need to lint 🫠 |
|
Wait for #7 to be merged and need to rebase on new mainline. |
|
@prometherion the PR Is now rebased and ready for review 🚀 |
prometherion
requested changes
Feb 7, 2024
|
|
||
| // Set the Tenant owner reference on the Namespace specified. | ||
| func (r *ServiceAccountReconciler) setNamespaceOwnerRef(ctx context.Context, ns *corev1.Namespace, tnt *capsulev1beta2.Tenant) error { | ||
| scheme := runtime.NewScheme() |
There was a problem hiding this comment.
You can extract the Scheme from the controller runtime client already injected, if these ones are already registered in the manager setup.
There was a problem hiding this comment.
Thanks. Applied @prometherion PTAL
Signed-off-by: Massimiliano Giovagnoli <[email protected]>
Signed-off-by: Massimiliano Giovagnoli <[email protected]>
prometherion
approved these changes
Feb 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3