Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More test fixes #7266

Merged
merged 6 commits into from
Sep 14, 2024
Merged

More test fixes #7266

merged 6 commits into from
Sep 14, 2024

Conversation

davepagurek
Copy link
Contributor

  • Adds pixelDensity(1) to texture tests so that running tests on a high dpi display doesn't cause them to break
  • Replaces the image diff library with something more custom so that we can try to accommodate pixel shifts better
  • Removes old unused browser-based visual test runner

@davepagurek
Copy link
Contributor Author

@sproutleaf I've skipped the param validation tests for now, we should look into those and get them running again.

@limzykenneth looks like all the (non-skipped) tests pass on CI now! we have the green checkmark back!!

@davepagurek davepagurek merged commit b3992f4 into dev-2.0 Sep 14, 2024
2 checks passed
@davepagurek davepagurek deleted the fix/tests branch September 14, 2024 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant