Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] React FC conversion for editor file retry + codemirror update using uiw/react-codemirrror #3230

Draft
wants to merge 8 commits into
base: develop
Choose a base branch
from

Conversation

nahbee10
Copy link
Collaborator

@nahbee10 nahbee10 commented Sep 10, 2024

Fixes #issue-number

Changes:

  • using EditorView along with editorView as a react state instead of cmInstance.current
  • using view.dispatch when changes need to be applied to the view instead of calling the function directly from the instance
  • change linter/emmet usage style to accommodate the updates from codemirror 6
  • will work on creating separate hook(useCodemirror) to set up the codemirror view to clean up the code

I have verified that this pull request:

  • has no linting errors (npm run lint)
  • has no test errors (npm run test)
  • is from a uniquely-named feature branch and is up to date with the develop branch.
  • is descriptively named and links to an issue number, i.e. Fixes #123

@nahbee10 nahbee10 marked this pull request as draft September 10, 2024 00:55
Copy link

release-com bot commented Sep 10, 2024

Release Environments

This Environment is provided by Release, learn more!
To see the status of the Environment click on Environment Status below.

🔧Environment Status : https://app.release.com/public/Processing%20Foundation/env-fdb9d83e1a

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant