The upload file button will be disabled after reaching the limit 250MB #3219
Conversation
| @@ -11,6 +11,7 @@ import DownArrowIcon from '../../../images/down-filled-triangle.svg'; | |||
| import FolderRightIcon from '../../../images/triangle-arrow-right.svg'; | |||
| import FolderDownIcon from '../../../images/triangle-arrow-down.svg'; | |||
| import FileTypeIcon from './FileTypeIcon'; | |||
| import { sizeLimit, currentSize } from './AssetSize'; | |||
There was a problem hiding this comment.
This doesn't seem to import the correct constants you've created in AssetSize.jsx!
| > | ||
| {t('FileNode.UploadFile')} | ||
| </button> | ||
| {currentSize < sizeLimit ? ( |
There was a problem hiding this comment.
Maybe this could be handled by changing the css property depending on currentSize < sizeLimit rather than the whole button?
|
Thanks so much for your work on this! After reviewing this, it seems like you're trying to add an alert message once a user has reached the 250MB limit for storing assets. We do have error handling for this implemented already in the File Upload Modal ( I don't think the overall changes here are addressing the original issue, but I've left a few notes on what's here so far! I feel that the original issue seems to involve how the asset sizes are being determined, so it might be better to try working from there instead. I'm going to close this pull request for now, but please feel free to revisit this with any updates! |
Fixes #issue-number: Error message claiming size limit of 250MB reached #2080
Changes:
I have verified that this pull request:
npm run lint)npm run test)developbranch.Fixes #123