Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support typescript #3216

Closed

Conversation

suprabhat15
Copy link
Contributor

@suprabhat15 suprabhat15 commented Aug 10, 2024

Fixes #2354

Changes:

  • Added typescript support by transpiling ts code into js based on discussion and suggestion
  • Added typescript icon when .ts file is created
ts.support.mov

I have verified that this pull request:

  • [✅] has no linting errors (npm run lint)
  • [✅] has no test errors (npm run test)
  • [✅] is from a uniquely-named feature branch and is up to date with the develop branch.
  • [✅] is descriptively named and links to an issue number, i.e. Fixes #123

@suprabhat15
Copy link
Contributor Author

@raclim @lindapaiste could you please review this?

@raclim
Copy link
Collaborator

raclim commented Aug 12, 2024

Thank you so much for your work on this!

Currently, we're trying to keep changes to features related to the text editor and the TypeScript integration to a minimum, as they are being handled by our fellow for this summer. I think this might conflict with some of their work, so I don't think we can accept this PR for now but will revisit it again if we determine that might not be the case anymore. I'm really sorry that we couldn't get this in, but please feel free to check out our other issues, thanks again!

@raclim raclim closed this Aug 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Typescript support
2 participants