Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed color of sketch lines to theme color #3210

Merged
merged 6 commits into from
Aug 12, 2024

Conversation

Noorain464
Copy link

@Noorain464 Noorain464 commented Aug 6, 2024

Fixes #issue-number
The color of sketch link in sketches table should be changed to theme color when hovered #2943

Changes:

I have verified that this pull request:

  • has no linting errors (npm run lint)
  • has no test errors (npm run test)
  • is from a uniquely-named feature branch and is up to date with the develop branch.
  • is descriptively named and links to an issue number, i.e. Fixes #123

Copy link

welcome bot commented Aug 6, 2024

🎉 Thanks for opening this pull request! Please check out our contributing guidelines if you haven't already.

@SableRaf
Copy link
Contributor

SableRaf commented Aug 6, 2024

Hi @Noorain464 and welcome to the p5.js-web-editor repository!

Could you please add details about the issue you're fixing? This will help us understand your changes better.

@Noorain464
Copy link
Author

I'm sorry, this is the issue I've solved
The color of sketch link in sketches table should be changed to theme color when hovered #2943
image

@Noorain464 Noorain464 changed the title Solved Issue Changed Color of sketch lines to theme color Aug 12, 2024
@Noorain464 Noorain464 changed the title Changed Color of sketch lines to theme color Changed color of sketch lines to theme color Aug 12, 2024
Copy link
Author

@Noorain464 Noorain464 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay Done.

Copy link
Collaborator

@raclim raclim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your work on this! I'm a little concerned about inconsistencies with how links should appear in the editor, but I think this is an improvement from what it currently looks like, I feel like this is good for now!

A few other points to note:

  • Although you included a screenshot, the image doesn't seem to reflect the specific changes. I added in a few images below of what it would ideally look like (i.e the changes in different themes). It would be great if you could add these types of details in future PRs!
Screenshot 2024-08-12 at 10 04 37 AM Screenshot 2024-08-12 at 10 04 52 AM
  • I removed some changes to the previewServer.js file, which I noticed is in another pull request you submitted. Ideally, we also would like to keep changes for issues separated in each pull request.

Thanks!

@raclim raclim merged commit 41d0303 into processing:develop Aug 12, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants