Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix closing of projectoptions on losing focus #3205

Merged
merged 3 commits into from
Aug 12, 2024
Merged

fix closing of projectoptions on losing focus #3205

merged 3 commits into from
Aug 12, 2024

Conversation

suprabhat15
Copy link
Contributor

Fixes #3204

Changes:

  • Updated onBlurComponent as soon as projectOptions loose focus.
  • Removed definition of onFocusComponent and its usage as it's not required.

I have verified that this pull request:

  • [ ✅ ] has no linting errors (npm run lint)
  • [ ✅ ] has no test errors (npm run test)
  • [ ✅ ] is from a uniquely-named feature branch and is up to date with the develop branch.
  • [ ✅ ] is descriptively named and links to an issue number, i.e. Fixes #123

@welcome Welcome
Copy link

welcome bot commented Aug 3, 2024

🎉 Thanks for opening this pull request! Please check out our contributing guidelines if you haven't already.

@suprabhat15 suprabhat15 marked this pull request as draft August 6, 2024 18:51
@suprabhat15 suprabhat15 marked this pull request as ready for review August 6, 2024 19:29
@suprabhat15
Copy link
Contributor Author

@raclim could you please review this PR?

raclim
raclim approved these changes Aug 12, 2024
View reviewed changes
Copy link
Collaborator

@raclim raclim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for your work and patience on this! This overall looks good to me!

@raclim raclim merged commit cb0e8d3 into processing:develop Aug 12, 2024
1 check passed
@suprabhat15 suprabhat15 deleted the fix-projectoptions-closing branch August 12, 2024 14:10
@suprabhat15 suprabhat15 restored the fix-projectoptions-closing branch August 12, 2024 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raclim raclim raclim approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ProjectOptions should be closed on losing focus but it's not working
2 participants
@suprabhat15 @raclim