Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: replace merge() with Object.assign() #24

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Commits on Oct 13, 2021

  1. fix: replace merge() with Object.assign()

    ## Background
    
    In my tests - I often spin up servers as part of `beforeEach`. In the particular area where I encountered problems is that my test server kept track of incoming requests by a mutable array. Couldn't for the life of me understand why the array was constantly empty, but I think this was the culprit.
    
    To be even more specific, I was testing a websocket trigger/receiver - so I in my tests I dynamically use `http.createServer()` & later I want to assert that the server received events as after doing specific actions in my app.
    KATT committed Oct 13, 2021
    Configuration menu
    Copy the full SHA
    0d31c39 View commit details
    Browse the repository at this point in the history