Fix selectors :not(.a,.b) #161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grosser
reviewed
May 29, 2024
grosser
reviewed
May 29, 2024
stoivo
force-pushed
the
v2-rule-set-selector
branch
from
33e89e7
to
4bf6c6d
Compare
|
rebased on |
stoivo
force-pushed
the
v2-rule-set-selector
branch
3 times, most recently
from
4070450
to
40b4d54
Compare
|
Jruby is failing because of a bug in jruby jruby/jruby#8283 @grosser Can we set jruby to be allowed to fail? |
|
yeah sure 👍 |
|
best link to to bug next to the allow-fail |
|
actually it, headius fixed it yesterday jruby/jruby#8283 |
stoivo
force-pushed
the
v2-rule-set-selector
branch
from
1c1f358
to
0400f72
Compare
|
lets give it a couple of days and see if jruby-head fixes itself |
stoivo
force-pushed
the
v2-rule-set-selector
branch
from
0400f72
to
2dc3f7c
Compare
|
Yay, jruby is working again. |
|
Time to merge |
|
awesome :D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #160
Why and what is being done.
Pre-Merge Checklist