Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add docs build readme #3930

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Add docs build readme #3930

wants to merge 5 commits into from

Conversation

bsardo
Copy link
Collaborator

@bsardo bsardo commented Sep 18, 2024

No description provided.

@bsardo
Copy link
Collaborator Author

bsardo commented Sep 19, 2024

@justadreamer

@bsardo
Copy link
Collaborator Author

bsardo commented Sep 19, 2024 •
edited
Loading

@SyntaxNode any thoughts on where we should put this README? I was going to put it in a build directory but that is actually a build process artifact which is ignored in gitignore.

Discussed offline. We'll put it in docs/build

@bsardo bsardo assigned SyntaxNode and hhhjort and unassigned SyntaxNode Sep 19, 2024
@bsardo bsardo marked this pull request as ready for review September 19, 2024 17:56
@bsardo bsardo changed the title Add build & run readme Add docs build readme Sep 19, 2024
@hhhjort
Copy link
Collaborator

hhhjort commented Sep 19, 2024

Just a note for linux, apt-get is for debian based distributions. Red Hat based ones would use rpm, unless that has changed. But I would think anyone who wants to build on a linux system would know what their package manager is.

hhhjort
hhhjort previously approved these changes Sep 19, 2024
View reviewed changes
@bsardo
Copy link
Collaborator Author

bsardo commented Sep 19, 2024 •
edited
Loading

Just a note for linux, apt-get is for debian based distributions. Red Hat based ones would use rpm, unless that has changed. But I would think anyone who wants to build on a linux system would know what their package manager is.

Gotcha I'll make that clear. I know @justadreamer tested on debian based distributions and he provided the linux instructions.

@bsardo bsardo assigned guscarreon and unassigned SyntaxNode Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hhhjort hhhjort hhhjort approved these changes

At least 2 approving reviews are required to merge this pull request.

Assignees

@guscarreon guscarreon

@hhhjort hhhjort

Labels
do not port
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bsardo @hhhjort @SyntaxNode @guscarreon