Triplelift Native: Mapping tag_code #3745

patrickloughrey · 2024-06-11T17:42:52Z

Moving forward, Triplelift's native bid adapter has to copy the value of imp.ext.data.tag_code and set it as imp.tagid which Triplelift uses for placement mapping if the specified publisher is sending the request.

…rver

github-actions · 2024-06-11T18:40:47Z

Code coverage summary

Note:

Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
Coverage summary encompasses all commits leading up to the latest one, 5831b00

triplelift_native

Refer here for heat map coverage report

github.com/prebid/prebid-server/v2/adapters/triplelift_native/triplelift_native.go:36:	getBidType		100.0%
github.com/prebid/prebid-server/v2/adapters/triplelift_native/triplelift_native.go:40:	processImp		85.0%
github.com/prebid/prebid-server/v2/adapters/triplelift_native/triplelift_native.go:77:	effectivePubID		88.9%
github.com/prebid/prebid-server/v2/adapters/triplelift_native/triplelift_native.go:93:	MakeRequests		92.9%
github.com/prebid/prebid-server/v2/adapters/triplelift_native/triplelift_native.go:138:	getPublisher		100.0%
github.com/prebid/prebid-server/v2/adapters/triplelift_native/triplelift_native.go:145:	getBidCount		100.0%
github.com/prebid/prebid-server/v2/adapters/triplelift_native/triplelift_native.go:153:	MakeBids		94.7%
github.com/prebid/prebid-server/v2/adapters/triplelift_native/triplelift_native.go:190:	Builder			100.0%
github.com/prebid/prebid-server/v2/adapters/triplelift_native/triplelift_native.go:209:	getExtraInfo		100.0%
github.com/prebid/prebid-server/v2/adapters/triplelift_native/triplelift_native.go:222:	getDefaultExtraInfo	100.0%
total:											(statements)		92.9%

adapters/triplelift_native/triplelift_native.go

github-actions · 2024-07-01T18:28:36Z

Code coverage summary

Note:

Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
Coverage summary encompasses all commits leading up to the latest one, a710384

triplelift_native

Refer here for heat map coverage report

github.com/prebid/prebid-server/v2/adapters/triplelift_native/triplelift_native.go:36:	getBidType		100.0%
github.com/prebid/prebid-server/v2/adapters/triplelift_native/triplelift_native.go:40:	processImp		85.0%
github.com/prebid/prebid-server/v2/adapters/triplelift_native/triplelift_native.go:77:	effectivePubID		88.9%
github.com/prebid/prebid-server/v2/adapters/triplelift_native/triplelift_native.go:93:	MakeRequests		92.9%
github.com/prebid/prebid-server/v2/adapters/triplelift_native/triplelift_native.go:138:	getPublisher		100.0%
github.com/prebid/prebid-server/v2/adapters/triplelift_native/triplelift_native.go:145:	getBidCount		100.0%
github.com/prebid/prebid-server/v2/adapters/triplelift_native/triplelift_native.go:153:	MakeBids		94.7%
github.com/prebid/prebid-server/v2/adapters/triplelift_native/triplelift_native.go:190:	Builder			100.0%
github.com/prebid/prebid-server/v2/adapters/triplelift_native/triplelift_native.go:209:	getExtraInfo		100.0%
github.com/prebid/prebid-server/v2/adapters/triplelift_native/triplelift_native.go:222:	getDefaultExtraInfo	100.0%
total:											(statements)		92.9%

adapters/triplelift_native/triplelift_native.go

github-actions · 2024-07-05T20:14:41Z

Code coverage summary

Note:

Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
Coverage summary encompasses all commits leading up to the latest one, 9af6f57

triplelift_native

Refer here for heat map coverage report

github.com/prebid/prebid-server/v2/adapters/triplelift_native/triplelift_native.go:45:	getBidType		100.0%
github.com/prebid/prebid-server/v2/adapters/triplelift_native/triplelift_native.go:49:	processImp		92.3%
github.com/prebid/prebid-server/v2/adapters/triplelift_native/triplelift_native.go:97:	effectivePubID		88.9%
github.com/prebid/prebid-server/v2/adapters/triplelift_native/triplelift_native.go:113:	MakeRequests		92.9%
github.com/prebid/prebid-server/v2/adapters/triplelift_native/triplelift_native.go:158:	getPublisher		100.0%
github.com/prebid/prebid-server/v2/adapters/triplelift_native/triplelift_native.go:165:	getBidCount		100.0%
github.com/prebid/prebid-server/v2/adapters/triplelift_native/triplelift_native.go:173:	MakeBids		94.7%
github.com/prebid/prebid-server/v2/adapters/triplelift_native/triplelift_native.go:210:	Builder			100.0%
github.com/prebid/prebid-server/v2/adapters/triplelift_native/triplelift_native.go:229:	getExtraInfo		100.0%
github.com/prebid/prebid-server/v2/adapters/triplelift_native/triplelift_native.go:242:	getDefaultExtraInfo	100.0%
total:											(statements)		94.3%

github-actions · 2024-07-05T20:21:31Z

Code coverage summary

Note:

Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
Coverage summary encompasses all commits leading up to the latest one, 788502a

triplelift_native

Refer here for heat map coverage report

github.com/prebid/prebid-server/v2/adapters/triplelift_native/triplelift_native.go:45:	getBidType		100.0%
github.com/prebid/prebid-server/v2/adapters/triplelift_native/triplelift_native.go:49:	processImp		92.3%
github.com/prebid/prebid-server/v2/adapters/triplelift_native/triplelift_native.go:97:	effectivePubID		88.9%
github.com/prebid/prebid-server/v2/adapters/triplelift_native/triplelift_native.go:113:	MakeRequests		92.9%
github.com/prebid/prebid-server/v2/adapters/triplelift_native/triplelift_native.go:158:	getPublisher		100.0%
github.com/prebid/prebid-server/v2/adapters/triplelift_native/triplelift_native.go:165:	getBidCount		100.0%
github.com/prebid/prebid-server/v2/adapters/triplelift_native/triplelift_native.go:173:	MakeBids		94.7%
github.com/prebid/prebid-server/v2/adapters/triplelift_native/triplelift_native.go:210:	Builder			100.0%
github.com/prebid/prebid-server/v2/adapters/triplelift_native/triplelift_native.go:229:	getExtraInfo		100.0%
github.com/prebid/prebid-server/v2/adapters/triplelift_native/triplelift_native.go:242:	getDefaultExtraInfo	100.0%
total:											(statements)		94.3%

bsardo · 2024-07-22T16:58:11Z

adapters/triplelift_native/triplelift_native.go

+
+	if extData.TagCode != "" {
+		if siteCopy.Publisher.Domain == "msn.com" {
+			fmt.Println(extData.TagCode)


Can you delete this print statement please?

adapters/triplelift_native/triplelift_native.go

github-actions · 2024-07-23T14:37:40Z

Code coverage summary

Note:

Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
Coverage summary encompasses all commits leading up to the latest one, f7379c6

triplelift_native

Refer here for heat map coverage report

github.com/prebid/prebid-server/v2/adapters/triplelift_native/triplelift_native.go:45:	getBidType		100.0%
github.com/prebid/prebid-server/v2/adapters/triplelift_native/triplelift_native.go:49:	processImp		92.3%
github.com/prebid/prebid-server/v2/adapters/triplelift_native/triplelift_native.go:97:	effectivePubID		88.9%
github.com/prebid/prebid-server/v2/adapters/triplelift_native/triplelift_native.go:113:	MakeRequests		92.9%
github.com/prebid/prebid-server/v2/adapters/triplelift_native/triplelift_native.go:158:	getPublisher		100.0%
github.com/prebid/prebid-server/v2/adapters/triplelift_native/triplelift_native.go:165:	getBidCount		100.0%
github.com/prebid/prebid-server/v2/adapters/triplelift_native/triplelift_native.go:173:	MakeBids		94.7%
github.com/prebid/prebid-server/v2/adapters/triplelift_native/triplelift_native.go:210:	Builder			100.0%
github.com/prebid/prebid-server/v2/adapters/triplelift_native/triplelift_native.go:229:	getExtraInfo		100.0%
github.com/prebid/prebid-server/v2/adapters/triplelift_native/triplelift_native.go:242:	getDefaultExtraInfo	100.0%
total:											(statements)		94.3%

github-actions · 2024-07-23T14:39:22Z

Code coverage summary

Note:

Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
Coverage summary encompasses all commits leading up to the latest one, 2bdc52a

triplelift_native

Refer here for heat map coverage report

github.com/prebid/prebid-server/v2/adapters/triplelift_native/triplelift_native.go:45:	getBidType		100.0%
github.com/prebid/prebid-server/v2/adapters/triplelift_native/triplelift_native.go:49:	processImp		92.0%
github.com/prebid/prebid-server/v2/adapters/triplelift_native/triplelift_native.go:96:	effectivePubID		88.9%
github.com/prebid/prebid-server/v2/adapters/triplelift_native/triplelift_native.go:112:	MakeRequests		92.9%
github.com/prebid/prebid-server/v2/adapters/triplelift_native/triplelift_native.go:157:	getPublisher		100.0%
github.com/prebid/prebid-server/v2/adapters/triplelift_native/triplelift_native.go:164:	getBidCount		100.0%
github.com/prebid/prebid-server/v2/adapters/triplelift_native/triplelift_native.go:172:	MakeBids		94.7%
github.com/prebid/prebid-server/v2/adapters/triplelift_native/triplelift_native.go:209:	Builder			100.0%
github.com/prebid/prebid-server/v2/adapters/triplelift_native/triplelift_native.go:228:	getExtraInfo		100.0%
github.com/prebid/prebid-server/v2/adapters/triplelift_native/triplelift_native.go:241:	getDefaultExtraInfo	100.0%
total:											(statements)		94.2%

github-actions · 2024-07-23T18:38:42Z

Code coverage summary

Note:

Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
Coverage summary encompasses all commits leading up to the latest one, e9b9346

triplelift_native

Refer here for heat map coverage report

github.com/prebid/prebid-server/v2/adapters/triplelift_native/triplelift_native.go:45:	getBidType		100.0%
github.com/prebid/prebid-server/v2/adapters/triplelift_native/triplelift_native.go:49:	processImp		96.0%
github.com/prebid/prebid-server/v2/adapters/triplelift_native/triplelift_native.go:96:	effectivePubID		88.9%
github.com/prebid/prebid-server/v2/adapters/triplelift_native/triplelift_native.go:112:	MakeRequests		92.9%
github.com/prebid/prebid-server/v2/adapters/triplelift_native/triplelift_native.go:157:	getPublisher		100.0%
github.com/prebid/prebid-server/v2/adapters/triplelift_native/triplelift_native.go:164:	getBidCount		100.0%
github.com/prebid/prebid-server/v2/adapters/triplelift_native/triplelift_native.go:172:	MakeBids		94.7%
github.com/prebid/prebid-server/v2/adapters/triplelift_native/triplelift_native.go:209:	Builder			100.0%
github.com/prebid/prebid-server/v2/adapters/triplelift_native/triplelift_native.go:228:	getExtraInfo		100.0%
github.com/prebid/prebid-server/v2/adapters/triplelift_native/triplelift_native.go:241:	getDefaultExtraInfo	100.0%
total:											(statements)		95.2%

patrickloughrey added 13 commits October 26, 2022 11:55

Triplelift: adding native endpoint

af6ee65

Triplelift: adding native endpoint

0d8d6f7

Merge branch 'prebid:master' into master

409ec19

Merge branch 'prebid:master' into master

8d02b4a

Adding GPP support

1558343

Adding GPP support

b589893

Merge branch 'prebid:master' into master

d838adf

Merge branch 'prebid:master' into master

c126782

Triplelift: mapping tag_code

394f8ba

Merge branch 'master' of https://github.com/patrickloughrey/prebid-se…

d8dd2f7

…rver

Merge branch 'prebid:master' into master

5680b42

Triplelift: mapping tag_code

08bca4b

Merge branch 'master' of https://github.com/patrickloughrey/prebid-se…

24d292d

…rver

patrickloughrey marked this pull request as draft June 11, 2024 17:46

patrickloughrey added 2 commits June 11, 2024 13:52

Triplelift: mapping tag_code

f76615a

Fix ext parsing

5831b00

patrickloughrey marked this pull request as ready for review June 11, 2024 18:46

bsardo changed the title ~~Triplelift Native Bid Adapter: Mapping tag_code~~ Triplelift Native: Mapping tag_code Jun 11, 2024

gargcreation1992 reviewed Jul 1, 2024

View reviewed changes

adapters/triplelift_native/triplelift_native.go Show resolved Hide resolved

gargcreation1992 assigned gargcreation1992 and Sonali-More-Xandr Jul 1, 2024

Merge branch 'prebid:master' into master

a710384

Adding test params

2cf98db

Kevin-P-Kerr suggested changes Jul 2, 2024

View reviewed changes

adapters/triplelift_native/triplelift_native.go Show resolved Hide resolved

adapters/triplelift_native/triplelift_native.go Outdated Show resolved Hide resolved

patrickloughrey added 3 commits July 5, 2024 11:33

Fixing placement parsing logic

914cd4c

Merge branch 'prebid:master' into master

4bb4a02

Fixing placement parsing logic

9af6f57

Fixing placement parsing logic

788502a

Sonali-More-Xandr previously approved these changes Jul 8, 2024

View reviewed changes

bsardo assigned przemkaczmarek and unassigned gargcreation1992 Jul 18, 2024

bsardo reviewed Jul 22, 2024

View reviewed changes

bsardo assigned bsardo and unassigned Sonali-More-Xandr Jul 22, 2024

Merge branch 'prebid:master' into master

f7379c6

Removing log statements

2bdc52a

patrickloughrey dismissed Sonali-More-Xandr’s stale review via 2bdc52a July 23, 2024 14:38

patrickloughrey added 2 commits July 23, 2024 14:34

Added test case for inner else

eeeff4f

Added test case for inner else

e9b9346

bsardo approved these changes Jul 24, 2024

View reviewed changes

przemkaczmarek approved these changes Jul 24, 2024

View reviewed changes

bsardo merged commit 536821f into prebid:master Jul 24, 2024
5 checks passed

cross-repo-issue-creation bot mentioned this pull request Jul 24, 2024

Port PR from PBS-Go: Triplelift Native: Mapping tag_code prebid/prebid-server-java#3325

Closed

guscarreon mentioned this pull request Jul 26, 2024

Triplelift Native: fix panic #3825

Closed

przemkaczmarek unassigned bsardo Jul 29, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Triplelift Native: Mapping tag_code #3745

Triplelift Native: Mapping tag_code #3745

patrickloughrey commented Jun 11, 2024

github-actions bot commented Jun 11, 2024

github-actions bot commented Jul 1, 2024

github-actions bot commented Jul 5, 2024

github-actions bot commented Jul 5, 2024

bsardo Jul 22, 2024

github-actions bot commented Jul 23, 2024

github-actions bot commented Jul 23, 2024

github-actions bot commented Jul 23, 2024

Triplelift Native: Mapping tag_code #3745

Triplelift Native: Mapping tag_code #3745

Conversation

patrickloughrey commented Jun 11, 2024

github-actions bot commented Jun 11, 2024

Code coverage summary

triplelift_native

github-actions bot commented Jul 1, 2024

Code coverage summary

triplelift_native

github-actions bot commented Jul 5, 2024

Code coverage summary

triplelift_native

github-actions bot commented Jul 5, 2024

Code coverage summary

triplelift_native

bsardo Jul 22, 2024

Choose a reason for hiding this comment

github-actions bot commented Jul 23, 2024

Code coverage summary

triplelift_native

github-actions bot commented Jul 23, 2024

Code coverage summary

triplelift_native

github-actions bot commented Jul 23, 2024

Code coverage summary

triplelift_native