Bizzclick: rename bizzclick to blasto #3688

BizzClick · 2024-05-17T18:56:37Z

Bizzclick has a big update, we are officially changing our name to blasto.

Related PR to prebid.github.io

github-actions · 2024-05-17T19:02:21Z

Code coverage summary

Note:

Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
Coverage summary encompasses all commits leading up to the latest one, 4912ca1

blasto

Refer here for heat map coverage report

github.com/prebid/prebid-server/v2/adapters/blasto/blasto.go:21:	Builder				100.0%
github.com/prebid/prebid-server/v2/adapters/blasto/blasto.go:33:	getHeaders			100.0%
github.com/prebid/prebid-server/v2/adapters/blasto/blasto.go:56:	MakeRequests			83.3%
github.com/prebid/prebid-server/v2/adapters/blasto/blasto.go:90:	getImpressionExt		85.7%
github.com/prebid/prebid-server/v2/adapters/blasto/blasto.go:107:	buildEndpointURL		100.0%
github.com/prebid/prebid-server/v2/adapters/blasto/blasto.go:120:	checkResponseStatusCodes	100.0%
github.com/prebid/prebid-server/v2/adapters/blasto/blasto.go:142:	MakeBids			100.0%
github.com/prebid/prebid-server/v2/adapters/blasto/blasto.go:188:	getMediaTypeForImp		100.0%
total:									(statements)			96.2%

github-actions · 2024-05-20T09:51:17Z

Code coverage summary

Note:

Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
Coverage summary encompasses all commits leading up to the latest one, eb01327

blasto

Refer here for heat map coverage report

github.com/prebid/prebid-server/v2/adapters/blasto/blasto.go:21:	Builder				100.0%
github.com/prebid/prebid-server/v2/adapters/blasto/blasto.go:33:	getHeaders			100.0%
github.com/prebid/prebid-server/v2/adapters/blasto/blasto.go:56:	MakeRequests			83.3%
github.com/prebid/prebid-server/v2/adapters/blasto/blasto.go:90:	getImpressionExt		85.7%
github.com/prebid/prebid-server/v2/adapters/blasto/blasto.go:107:	buildEndpointURL		100.0%
github.com/prebid/prebid-server/v2/adapters/blasto/blasto.go:120:	checkResponseStatusCodes	100.0%
github.com/prebid/prebid-server/v2/adapters/blasto/blasto.go:142:	MakeBids			100.0%
github.com/prebid/prebid-server/v2/adapters/blasto/blasto.go:188:	getMediaTypeForImp		100.0%
total:									(statements)			96.2%

exchange/adapter_builders.go

onkarvhanumante · 2024-05-23T10:17:14Z

@BizzClick

Consider adding blasto in DisabledBidderWarningMessages map.

prebid-server/exchange/adapter_util.go

Lines 106 to 123 in ec729e6

    
           func GetDisabledBidderWarningMessages(infos config.BidderInfos) map[string]string { 
        
           	removed := map[string]string{ 
        
           		"lifestreet":      `Bidder "lifestreet" is no longer available in Prebid Server. Please update your configuration.`, 
        
           		"adagio":          `Bidder "adagio" is no longer available in Prebid Server. Please update your configuration.`, 
        
           		"somoaudience":    `Bidder "somoaudience" is no longer available in Prebid Server. Please update your configuration.`, 
        
           		"yssp":            `Bidder "yssp" is no longer available in Prebid Server. If you're looking to use the Yahoo SSP adapter, please rename it to "yahooAds" in your configuration.`, 
        
           		"andbeyondmedia":  `Bidder "andbeyondmedia" is no longer available in Prebid Server. If you're looking to use the AndBeyond.Media SSP adapter, please rename it to "beyondmedia" in your configuration.`, 
        
           		"oftmedia":        `Bidder "oftmedia" is no longer available in Prebid Server. Please update your configuration.`, 
        
           		"groupm":          `Bidder "groupm" is no longer available in Prebid Server. Please update your configuration.`, 
        
           		"verizonmedia":    `Bidder "verizonmedia" is no longer available in Prebid Server. Please update your configuration.`, 
        
           		"brightroll":      `Bidder "brightroll" is no longer available in Prebid Server. Please update your configuration.`, 
        
           		"engagebdr":       `Bidder "engagebdr" is no longer available in Prebid Server. Please update your configuration.`, 
        
           		"ninthdecimal":    `Bidder "ninthdecimal" is no longer available in Prebid Server. Please update your configuration.`, 
        
           		"kubient":         `Bidder "kubient" is no longer available in Prebid Server. Please update your configuration.`, 
        
           		"applogy":         `Bidder "applogy" is no longer available in Prebid Server. Please update your configuration.`, 
        
           		"rhythmone":       `Bidder "rhythmone" is no longer available in Prebid Server. Please update your configuration.`, 
        
           		"nanointeractive": `Bidder "nanointeractive" is no longer available in Prebid Server. Please update your configuration.`, 
        
           	}

static/bidder-info/blasto.yaml

onkarvhanumante · 2024-05-23T10:25:40Z

static/bidder-info/blasto.yaml

-endpoint: 'http://{{.Host}}.bizzclick.com/bid?rtb_seat_id={{.SourceId}}&secret_key={{.AccountID}}'
+endpoint: 'http://{{.Host}}.blasto.ai/bid?rtb_seat_id={{.SourceId}}&secret_key={{.AccountID}}'


Usage of partial dynamic urls is being discouraged and prebid team in future will be working to avoid usage of dynamic subdomain in endpoint url.

Major concerns with such usage are,

security concerns
The security aspect is alleviated by using a fixed top level domain. Due to the potential harm to hosts, we are strict in this requirement. We are working towards fixing the few adapters currently in violation.

connection performance
The connection performance advice is for your benefit. Client specific subdomains prevent Prebid Server from reusing connections across your clients which results in more connections needed for your adapter. The issue gets worse the more successful you are in attracting new clients. Hosts may choose to disable your adapter due to this behavior.

I understand, do you have an alternative solution for such cases?

pass host as query string if you would like to.

@gargcreation1992 Do you mean like this http://blasto.ai/bid?rtb_seat_id={{.SourceId}}&secret_key={{.AccountID}}&host={{.Host}}?

I don't think we can do this, we have three regions with this subdomains:
us-e-node1 - us east, n1 - eu, n3 - apac. So this is the easiest way to do it, just to make subdomain dynamic

I understand, do you have an alternative solution for such cases?

In the case of region specific routing, we recommend the solution of documenting in the docs PR the different endpoints supported by your adapter and hosts can configure their data centers to match. PBS already allows endpoints to be configured via application settings (environment variable or pbs.yaml).

We don't like asking publishers to enter the region in each one of their placement configs. This is really a server level configuration.

@SyntaxNode Got it! Thus by default in blasto.yaml file I can define such endpoint with us east region

# We have the following regional endpoint sub-domains: # US East: us-e-node1 # EU: n1 # APAC: n3 # Please deploy this config in each of your datacenters with the appropriate regional subdomain endpoint: 'http://us-e-node1.blasto.ai/bid?rtb_seat_id={{.SourceId}}&secret_key={{.AccountID}}'

And then pbs.yaml can be modified accordingly to the region? For example:

adapters: blasto: endpoint: http://n1.blasto.ai/bid?rtb_seat_id={{.SourceId}}&secret_key={{.AccountID}}

Yes, exactly. You're also welcomed to disable the adapter by default with a placeholder endpoint like in the Rubicon adapter:

# Contact [email protected] to ask about enabling a connection to the Magnite (formerly Rubicon) exchange. # We have the following regional endpoint domains: exapi-us-east, exapi-us-west, exapi-apac, exapi-eu # Please deploy this config in each of your datacenters with the appropriate regional subdomain endpoint: "https://REGION.rubiconproject.com/a/api/exchange" disabled: true

Either are good approaches IMHO.

github-actions · 2024-05-24T11:21:29Z

Code coverage summary

Note:

Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
Coverage summary encompasses all commits leading up to the latest one, c505b26

blasto

Refer here for heat map coverage report

github.com/prebid/prebid-server/v2/adapters/blasto/blasto.go:21:	Builder				100.0%
github.com/prebid/prebid-server/v2/adapters/blasto/blasto.go:33:	getHeaders			100.0%
github.com/prebid/prebid-server/v2/adapters/blasto/blasto.go:56:	MakeRequests			83.3%
github.com/prebid/prebid-server/v2/adapters/blasto/blasto.go:90:	getImpressionExt		85.7%
github.com/prebid/prebid-server/v2/adapters/blasto/blasto.go:107:	buildEndpointURL		100.0%
github.com/prebid/prebid-server/v2/adapters/blasto/blasto.go:120:	checkResponseStatusCodes	100.0%
github.com/prebid/prebid-server/v2/adapters/blasto/blasto.go:142:	MakeBids			100.0%
github.com/prebid/prebid-server/v2/adapters/blasto/blasto.go:188:	getMediaTypeForImp		100.0%
total:									(statements)			96.2%

github-actions · 2024-05-24T11:42:28Z

Code coverage summary

Note:

Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
Coverage summary encompasses all commits leading up to the latest one, bd269e5

blasto

Refer here for heat map coverage report

github.com/prebid/prebid-server/v2/adapters/blasto/blasto.go:21:	Builder				100.0%
github.com/prebid/prebid-server/v2/adapters/blasto/blasto.go:33:	getHeaders			100.0%
github.com/prebid/prebid-server/v2/adapters/blasto/blasto.go:56:	MakeRequests			83.3%
github.com/prebid/prebid-server/v2/adapters/blasto/blasto.go:90:	getImpressionExt		85.7%
github.com/prebid/prebid-server/v2/adapters/blasto/blasto.go:107:	buildEndpointURL		100.0%
github.com/prebid/prebid-server/v2/adapters/blasto/blasto.go:120:	checkResponseStatusCodes	100.0%
github.com/prebid/prebid-server/v2/adapters/blasto/blasto.go:142:	MakeBids			100.0%
github.com/prebid/prebid-server/v2/adapters/blasto/blasto.go:188:	getMediaTypeForImp		100.0%
total:									(statements)			96.2%

github-actions · 2024-06-13T07:21:23Z

Code coverage summary

Note:

Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
Coverage summary encompasses all commits leading up to the latest one, c0af83d

blasto

Refer here for heat map coverage report

github.com/prebid/prebid-server/v2/adapters/blasto/blasto.go:21:	Builder				100.0%
github.com/prebid/prebid-server/v2/adapters/blasto/blasto.go:33:	getHeaders			100.0%
github.com/prebid/prebid-server/v2/adapters/blasto/blasto.go:56:	MakeRequests			83.3%
github.com/prebid/prebid-server/v2/adapters/blasto/blasto.go:90:	getImpressionExt		85.7%
github.com/prebid/prebid-server/v2/adapters/blasto/blasto.go:107:	buildEndpointURL		100.0%
github.com/prebid/prebid-server/v2/adapters/blasto/blasto.go:120:	checkResponseStatusCodes	100.0%
github.com/prebid/prebid-server/v2/adapters/blasto/blasto.go:142:	MakeBids			100.0%
github.com/prebid/prebid-server/v2/adapters/blasto/blasto.go:188:	getMediaTypeForImp		100.0%
total:									(statements)			96.2%

SyntaxNode · 2024-06-17T17:31:43Z

@BizzClick There was a comment on a similar PR recently where @bretg strongly felt the bizzclick name should rename active for a transition period unless there is literally zero current traffic. Is this the case for you? Does bizzclick currently receive no traffic?

bretg · 2024-06-17T17:37:53Z

https://docs.prebid.org/faq/prebid-server-faq.html#how-can-we-rename-our-bid-adapter

BizzClick · 2024-06-18T18:19:38Z

@SyntaxNode @bretg yes, bizzclick now has no traffic from pbs. Should i use aliasOf: "blasto" in existing bizzclick adapter?
I would prefer to rename the existing adapter with mentioning that it used to be bizzclick.

bretg · 2024-06-18T19:01:47Z

Should i use aliasOf: "blasto" in existing bizzclick adapter?

@BizzClick - yes, that is the guideline. Adding an alias differs in PBS-Go and PBS-Java. See

I would prefer to rename the existing adapter with mentioning that it used to be bizzclick.

If you are 110% sure that not a single Prebid Server host company is using your adapter, then ok. But if anyone is using bizzclick, changing the name is going to break them when they upgrade and then people are going to get mad at Prebid for you changing your name. There are probably at least 50 companies using Prebid Server... how can you be sure that no one has enabled your adapter?

BizzClick · 2024-06-19T14:44:13Z

@bretg i'm 110% sure about that and it was considered before renaming.
In any case someone from PBS community can contact our business team via email to confirm this.

bretg · 2024-06-20T13:03:02Z

i'm 110% sure about that

Very well.

bsardo · 2024-06-27T18:07:36Z

LGTM except for the YAML file update with respect to regional endpoints. We would also need to see another docs PR opened to capture the regional endpoint details.

github-actions · 2024-07-01T06:41:27Z

Code coverage summary

Note:

Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
Coverage summary encompasses all commits leading up to the latest one, 10ab052

blasto

Refer here for heat map coverage report

github.com/prebid/prebid-server/v2/adapters/blasto/blasto.go:21:	Builder				100.0%
github.com/prebid/prebid-server/v2/adapters/blasto/blasto.go:33:	getHeaders			100.0%
github.com/prebid/prebid-server/v2/adapters/blasto/blasto.go:56:	MakeRequests			83.3%
github.com/prebid/prebid-server/v2/adapters/blasto/blasto.go:90:	getImpressionExt		85.7%
github.com/prebid/prebid-server/v2/adapters/blasto/blasto.go:107:	buildEndpointURL		100.0%
github.com/prebid/prebid-server/v2/adapters/blasto/blasto.go:113:	checkResponseStatusCodes	100.0%
github.com/prebid/prebid-server/v2/adapters/blasto/blasto.go:135:	MakeBids			100.0%
github.com/prebid/prebid-server/v2/adapters/blasto/blasto.go:181:	getMediaTypeForImp		100.0%
total:									(statements)			95.9%

BizzClick · 2024-07-01T06:46:22Z

@bsardo sure, here's related PR
prebid/prebid.github.io#5466

rename bizzclick to blasto

b21c2a0

BizzClick mentioned this pull request May 17, 2024

Bizzclick Bid Adapter: rename bizzclick to blasto prebid/prebid.github.io#5326

Merged

3 tasks

fix: domain

4912ca1

BizzClick marked this pull request as ready for review May 18, 2024 20:16

update sub-domain in yaml

eb01327

SyntaxNode reviewed May 20, 2024

View reviewed changes

exchange/adapter_builders.go Show resolved Hide resolved

BizzClick changed the title ~~Bizzclick: rename bizzclick to blasto~~ Bizzclick Bid Adapter: rename bizzclick to blasto May 21, 2024

gargcreation1992 previously approved these changes May 22, 2024

View reviewed changes

gargcreation1992 assigned gargcreation1992 and onkarvhanumante May 22, 2024

onkarvhanumante reviewed May 23, 2024

View reviewed changes

static/bidder-info/blasto.yaml Outdated Show resolved Hide resolved

onkarvhanumante reviewed May 23, 2024

View reviewed changes

bsardo changed the title ~~Bizzclick Bid Adapter: rename bizzclick to blasto~~ Bizzclick: rename bizzclick to blasto May 23, 2024

BizzClick dismissed gargcreation1992’s stale review via c505b26 May 24, 2024 11:20

add bizzclick deprecated warning

bd269e5

BizzClick force-pushed the blasto branch from c505b26 to bd269e5 Compare May 24, 2024 11:41

BizzClick requested review from gargcreation1992 and onkarvhanumante June 11, 2024 13:17

Merge branch 'master' into blasto

c0af83d

BizzClick requested a review from SyntaxNode June 21, 2024 07:04

bsardo assigned bsardo and unassigned gargcreation1992 Jun 27, 2024

BizzClick mentioned this pull request Jul 1, 2024

Bizzclick Bid Adapter: remove deprecated params prebid/prebid.github.io#5466

Merged

7 tasks

remove host & placementId deprecated params

10ab052

onkarvhanumante approved these changes Jul 1, 2024

View reviewed changes

gargcreation1992 approved these changes Jul 1, 2024

View reviewed changes

gargcreation1992 merged commit 670e1d4 into prebid:master Jul 1, 2024
5 checks passed

cross-repo-issue-creation bot mentioned this pull request Jul 1, 2024

Port PR from PBS-Go: Bizzclick: rename bizzclick to blasto prebid/prebid-server-java#3277

Closed

mefjush pushed a commit to adhese/prebid-server that referenced this pull request Jul 19, 2024

Bizzclick: rename bizzclick to blasto (prebid#3688)

3a4fd0a

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Bizzclick: rename bizzclick to blasto #3688

Bizzclick: rename bizzclick to blasto #3688

BizzClick commented May 17, 2024

github-actions bot commented May 17, 2024

github-actions bot commented May 20, 2024

onkarvhanumante commented May 23, 2024

onkarvhanumante May 23, 2024

BizzClick May 24, 2024

gargcreation1992 May 27, 2024

BizzClick Jun 3, 2024

SyntaxNode Jun 24, 2024

BizzClick Jun 27, 2024

SyntaxNode Jun 27, 2024

BizzClick Jul 1, 2024

github-actions bot commented May 24, 2024

github-actions bot commented May 24, 2024

github-actions bot commented Jun 13, 2024

SyntaxNode commented Jun 17, 2024

bretg commented Jun 17, 2024

BizzClick commented Jun 18, 2024

bretg commented Jun 18, 2024

BizzClick commented Jun 19, 2024

bretg commented Jun 20, 2024

bsardo commented Jun 27, 2024

github-actions bot commented Jul 1, 2024

BizzClick commented Jul 1, 2024

		endpoint: 'http://{{.Host}}.bizzclick.com/bid?rtb_seat_id={{.SourceId}}&secret_key={{.AccountID}}'
		endpoint: 'http://{{.Host}}.blasto.ai/bid?rtb_seat_id={{.SourceId}}&secret_key={{.AccountID}}'

Bizzclick: rename bizzclick to blasto #3688

Bizzclick: rename bizzclick to blasto #3688

Conversation

BizzClick commented May 17, 2024

github-actions bot commented May 17, 2024

Code coverage summary

blasto

github-actions bot commented May 20, 2024

Code coverage summary

blasto

onkarvhanumante commented May 23, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

github-actions bot commented May 24, 2024

Code coverage summary

blasto

github-actions bot commented May 24, 2024

Code coverage summary

blasto

github-actions bot commented Jun 13, 2024

Code coverage summary

blasto

SyntaxNode commented Jun 17, 2024

bretg commented Jun 17, 2024

BizzClick commented Jun 18, 2024

bretg commented Jun 18, 2024

BizzClick commented Jun 19, 2024

bretg commented Jun 20, 2024

bsardo commented Jun 27, 2024

github-actions bot commented Jul 1, 2024

Code coverage summary

blasto

BizzClick commented Jul 1, 2024