-
Notifications
You must be signed in to change notification settings - Fork 721
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Metrics: Add per adapter metric indicating when buyeruid was scrubbed #3623
Merged
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
76b6fe8
Add per adapter metric indicating when buyeruid was scrubbed
bsardo 0b351bd
go fmt
bsardo 20e692e
Add config tests for metric disabled flag
bsardo d38a1d7
Fix bug and add test coverage for disabled case
bsardo 778da9b
Add missing test descriptions, convert tests to use t.Run, go fmt
bsardo 8e21a30
Use String() and change conditional to assignment statement
bsardo c22ee03
Refactor for readability
bsardo d6075c7
Disable metric by default
bsardo File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -188,20 +188,27 @@ func (rs *requestSplitter) cleanOpenRTBRequests(ctx context.Context, | |
} | ||
|
||
passIDActivityAllowed := auctionReq.Activities.Allow(privacy.ActivityTransmitUserFPD, scopedName, privacy.NewRequestFromBidRequest(*req)) | ||
buyerUIDSet := reqWrapper.User != nil && reqWrapper.User.BuyerUID != "" | ||
buyerUIDRemoved := false | ||
if !passIDActivityAllowed { | ||
//UFPD | ||
privacy.ScrubUserFPD(reqWrapper) | ||
buyerUIDRemoved = true | ||
} else { | ||
// run existing policies (GDPR, CCPA, COPPA, LMT) | ||
// potentially block passing IDs based on GDPR | ||
if gdprEnforced && (gdprErr != nil || !auctionPermissions.PassID) { | ||
privacy.ScrubGdprID(reqWrapper) | ||
buyerUIDRemoved = true | ||
} | ||
// potentially block passing IDs based on CCPA | ||
if ccpaEnforcer.ShouldEnforce(bidderRequest.BidderName.String()) { | ||
privacy.ScrubDeviceIDsIPsUserDemoExt(reqWrapper, ipConf, "eids", false) | ||
buyerUIDRemoved = true | ||
} | ||
} | ||
if buyerUIDSet && buyerUIDRemoved { | ||
rs.me.RecordAdapterBuyerUIDScrubbed(bidderRequest.BidderCoreName) | ||
} | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This works. Alternatively, we could track a second bool |
||
|
||
passGeoActivityAllowed := auctionReq.Activities.Allow(privacy.ActivityTransmitPreciseGeo, scopedName, privacy.NewRequestFromBidRequest(*req)) | ||
if !passGeoActivityAllowed { | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you add this field to config_test.go, with
TestDefaults
andTestFullConfig
?