Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix semgrep dgryski.semgrep-go issues #3511

Merged
merged 4 commits into from
Mar 25, 2024
Merged

Fix semgrep dgryski.semgrep-go issues #3511

merged 4 commits into from
Mar 25, 2024

Commits on Mar 13, 2024

  1. fix semgrep dgryski.semgrep-go issues 

    Fix most of the semgrep issues with the
http://semgrep.dev/r/dgryski.semgrep-go ruleset
(`semgrep --config http://semgrep.dev/r/dgryski.semgrep-go`).
Left the issue with Content-Type text/plain on json.Encode
in endpoints/openrtb2/amp_auction.go since changing to
application/json breaks the AMP unit tests, and issues
with the pointer receiver for MarshalJSON in usersync/cookie.go.

Fix prebid#3509.

Signed-off-by: Dmitry S <[email protected]>
    @dmitris
    dmitris committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    de9a3b8 View commit details
    Browse the repository at this point in the history

  2. add comment about legacy text/plain content type 

    Signed-off-by: Dmitry S <[email protected]>
    @dmitris
    dmitris committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    12ed1a0 View commit details
    Browse the repository at this point in the history

  3. fix semgrep dgryski issue with w.Write, add nosemgrep 

    Signed-off-by: Dmitry S <[email protected]>
    @dmitris
    dmitris committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    92602d0 View commit details
    Browse the repository at this point in the history

Commits on Mar 14, 2024

  1. add nosemgrep ignore for marshal-json-pointer-receiver

    @dmitris
    dmitris committed Mar 14, 2024
    Configuration menu
    Copy the full SHA
    9cc55f4 View commit details
    Browse the repository at this point in the history