Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stroeercore: Support DSA #3495

Merged
merged 1 commit into from
Feb 22, 2024
Merged

Stroeercore: Support DSA #3495

merged 1 commit into from
Feb 22, 2024

Conversation

philipwatson
Copy link
Contributor

Support for Digital Services Act (DSA)

@github-actions GitHub Actions
Copy link

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, 82f9bf5

stroeerCore

Refer here for heat map coverage report

github.com/prebid/prebid-server/v2/adapters/stroeerCore/stroeercore.go:41:	resolveMediaType	100.0%
github.com/prebid/prebid-server/v2/adapters/stroeerCore/stroeercore.go:52:	MakeBids		86.4%
github.com/prebid/prebid-server/v2/adapters/stroeerCore/stroeercore.go:108:	MakeRequests		70.0%
github.com/prebid/prebid-server/v2/adapters/stroeerCore/stroeercore.go:147:	Builder			100.0%
total:										(statements)		81.2%

@bsardo bsardo self-assigned this Feb 14, 2024
@bsardo bsardo changed the title Stroeercore: support DSA Stroeercore: Support DSA Feb 15, 2024
gargcreation1992
gargcreation1992 reviewed Feb 21, 2024
View reviewed changes
adapters/stroeerCore/stroeercore.go
if bid.DSA != nil {
dsaJson, err := json.Marshal(bidExt{bid.DSA})
if err != nil {
errors = append(errors, err)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you sure if you would like to continue if there is json Marshal error here? If not, then you need to continue in your for loop.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I'm sure. The idea is to keep the bid and let upstream decide what to do with it.

@gargcreation1992 gargcreation1992 merged commit 33b466e into prebid:master Feb 22, 2024
5 checks passed
@cross-repo-issue-creation cross-repo-issue-creation bot mentioned this pull request Feb 22, 2024
Closed
@philipwatson philipwatson deleted the stroeercore-dsa branch March 4, 2024 01:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bsardo bsardo bsardo approved these changes

@gargcreation1992 gargcreation1992 gargcreation1992 approved these changes

Assignees

@bsardo bsardo

@gargcreation1992 gargcreation1992

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@philipwatson @bsardo @gargcreation1992