New adapter: BoldwinX #3430

bold-win · 2024-01-26T13:00:40Z

github-actions · 2024-01-26T13:01:26Z

Code coverage summary

Note:

Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
Coverage summary encompasses all commits leading up to the latest one, f663567

bwx

Refer here for heat map coverage report

github.com/prebid/prebid-server/v2/adapters/bwx/bwx.go:29:	Builder				80.0%
github.com/prebid/prebid-server/v2/adapters/bwx/bwx.go:42:	buildEndpointFromRequest	100.0%
github.com/prebid/prebid-server/v2/adapters/bwx/bwx.go:65:	MakeRequests			89.5%
github.com/prebid/prebid-server/v2/adapters/bwx/bwx.go:102:	MakeBids			100.0%
github.com/prebid/prebid-server/v2/adapters/bwx/bwx.go:131:	prepareBidResponse		100.0%
github.com/prebid/prebid-server/v2/adapters/bwx/bwx.go:153:	getMediaTypeForBid		100.0%
total:								(statements)			94.9%

adapters/bwx/bwx.go

github-actions · 2024-01-30T15:40:31Z

Code coverage summary

Note:

Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
Coverage summary encompasses all commits leading up to the latest one, 2610848

bwx

Refer here for heat map coverage report

github.com/prebid/prebid-server/v2/adapters/bwx/bwx.go:29:	Builder				80.0%
github.com/prebid/prebid-server/v2/adapters/bwx/bwx.go:42:	buildEndpointFromRequest	100.0%
github.com/prebid/prebid-server/v2/adapters/bwx/bwx.go:65:	MakeRequests			89.5%
github.com/prebid/prebid-server/v2/adapters/bwx/bwx.go:102:	MakeBids			100.0%
github.com/prebid/prebid-server/v2/adapters/bwx/bwx.go:131:	prepareBidResponse		100.0%
github.com/prebid/prebid-server/v2/adapters/bwx/bwx.go:153:	getMediaTypeForBid		100.0%
total:								(statements)			94.9%

onkarvhanumante · 2024-02-02T08:24:18Z

adapters/bwx/bwx.go

+	bidResponse := adapters.NewBidderResponseWithBidsCapacity(len(seats))
+
+	for _, seatBid := range seats {
+		for bidId, bid := range seatBid.Bid {


bidId is actually index of loop iteration. Should consider renaming it to i or idx or index to avoid confusion between bidId and loop index

onkarvhanumante · 2024-02-02T08:25:22Z

adapters/bwx/bwx.go

+	default:
+		return "", fmt.Errorf("failed to parse bid mtype for impression id \"%s\"", bid.ImpID)
+	}


should also include received mtype in error message.

onkarvhanumante · 2024-02-02T08:26:45Z

static/bidder-info/bwx.yaml

@@ -0,0 +1,19 @@
+endpoint: "http://rtb.boldwin.live?pid={{.SourceId}}&host={{.Host}}&pbs=1"


endpoint is reachable

% curl -i --location --request POST 'http://rtb.boldwin.live?pid=12&host=1&pbs=1' HTTP/1.1 400 Bad Request

onkarvhanumante · 2024-02-02T08:30:28Z

static/bidder-info/bwx.yaml

@@ -0,0 +1,19 @@
+endpoint: "http://rtb.boldwin.live?pid={{.SourceId}}&host={{.Host}}&pbs=1"
+maintainer:
+  email: "[email protected]"


Prebid team has sent an email to verify specified maintainer's email address. Requesting to reply back on email with "received" message

email verified.

github-actions · 2024-02-02T11:24:22Z

Code coverage summary

Note:

Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
Coverage summary encompasses all commits leading up to the latest one, faeadd6

bwx

Refer here for heat map coverage report

github.com/prebid/prebid-server/v2/adapters/bwx/bwx.go:29:	Builder				80.0%
github.com/prebid/prebid-server/v2/adapters/bwx/bwx.go:42:	buildEndpointFromRequest	100.0%
github.com/prebid/prebid-server/v2/adapters/bwx/bwx.go:65:	MakeRequests			89.5%
github.com/prebid/prebid-server/v2/adapters/bwx/bwx.go:102:	MakeBids			100.0%
github.com/prebid/prebid-server/v2/adapters/bwx/bwx.go:131:	prepareBidResponse		100.0%
github.com/prebid/prebid-server/v2/adapters/bwx/bwx.go:153:	getMediaTypeForBid		100.0%
total:								(statements)			94.9%

bold-win · 2024-02-02T11:28:45Z

@onkarvhanumante done, thank you for review

gargcreation1992 · 2024-02-05T06:19:23Z

adapters/bwx/bwx.go

+	if bidderRawResponse.StatusCode == http.StatusServiceUnavailable {
+		return nil, []error{&errortypes.BadInput{
+			Message: "Bidder BoldwinX is unavailable. Please contact the bidder support.",
+		}}
+	}


This check should be covered by CheckResponseStatusCodeErrors func.

@gargcreation1992 done

…deForErrors

github-actions · 2024-02-05T11:45:36Z

Code coverage summary

Note:

Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
Coverage summary encompasses all commits leading up to the latest one, 9a7baae

bwx

Refer here for heat map coverage report

github.com/prebid/prebid-server/v2/adapters/bwx/bwx.go:29:	Builder				80.0%
github.com/prebid/prebid-server/v2/adapters/bwx/bwx.go:42:	buildEndpointFromRequest	100.0%
github.com/prebid/prebid-server/v2/adapters/bwx/bwx.go:65:	MakeRequests			89.5%
github.com/prebid/prebid-server/v2/adapters/bwx/bwx.go:102:	MakeBids			100.0%
github.com/prebid/prebid-server/v2/adapters/bwx/bwx.go:125:	prepareBidResponse		100.0%
github.com/prebid/prebid-server/v2/adapters/bwx/bwx.go:147:	getMediaTypeForBid		100.0%
total:								(statements)			94.7%

bold-win · 2024-02-06T13:24:43Z

@SyntaxNode Hi Scott! Could you please submit requested changes? Thank you

bold-win · 2024-02-07T15:05:00Z

Hi @onkarvhanumante,

Could you please let me know if there are any blockers to merge this PR? It would be great if bwx adapter could be included in the next release. Thank you!

SyntaxNode

Consider renaming "boldwinxtest" to "bwxtest" to follow the convention of using the adapter name.

SyntaxNode · 2024-02-08T16:40:55Z

adapters/bwx/bwxtest_test.go

The expected file name is bwx_test.go.

Please rename this file to follow common design patterns.

SyntaxNode · 2024-02-08T16:42:13Z

adapters/bwx/bwxtest_test.go

+
+	assert.NoError(t, buildErr)
+	adapterstest.RunJSONBidderTest(t, "boldwinxtest", bidder)
+}


Please add a builder test for the macro parsing error. Here's an example from aceex:

func TestEndpointTemplateMalformed(t *testing.T) { _, buildErr := Builder(openrtb_ext.BidderAceex, config.Adapter{ Endpoint: "{{Malformed}}"}, config.Server{ExternalUrl: "http://hosturl.com", GvlID: 1, DataCenter: "2"}) assert.Error(t, buildErr) }

adapters/bwx/params_test.go

static/bidder-params/bwx.json

github-actions · 2024-02-08T17:33:18Z

Code coverage summary

Note:

Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
Coverage summary encompasses all commits leading up to the latest one, 143844c

bwx

Refer here for heat map coverage report

github.com/prebid/prebid-server/v2/adapters/bwx/bwx.go:29:	Builder				100.0%
github.com/prebid/prebid-server/v2/adapters/bwx/bwx.go:42:	buildEndpointFromRequest	100.0%
github.com/prebid/prebid-server/v2/adapters/bwx/bwx.go:65:	MakeRequests			89.5%
github.com/prebid/prebid-server/v2/adapters/bwx/bwx.go:102:	MakeBids			100.0%
github.com/prebid/prebid-server/v2/adapters/bwx/bwx.go:125:	prepareBidResponse		100.0%
github.com/prebid/prebid-server/v2/adapters/bwx/bwx.go:147:	getMediaTypeForBid		100.0%
total:								(statements)			96.5%

bold-win · 2024-02-08T17:39:28Z

@SyntaxNode hello, thank you for review, now its done + dev-docs commit: prebid/prebid.github.io@4b70bcf

SyntaxNode

Thank you for the updates. Just two minor nitpicks left.

adapters/bwx/bwx.go

SyntaxNode · 2024-02-14T22:07:56Z

adapters/bwx/bwxtest_test.go

Please rename this file to follow common design patterns.

github-actions · 2024-02-15T13:52:38Z

Code coverage summary

Note:

Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
Coverage summary encompasses all commits leading up to the latest one, 8da1280

bwx

Refer here for heat map coverage report

github.com/prebid/prebid-server/v2/adapters/bwx/bwx.go:29:	Builder				100.0%
github.com/prebid/prebid-server/v2/adapters/bwx/bwx.go:42:	buildEndpointFromRequest	100.0%
github.com/prebid/prebid-server/v2/adapters/bwx/bwx.go:65:	MakeRequests			89.5%
github.com/prebid/prebid-server/v2/adapters/bwx/bwx.go:102:	MakeBids			100.0%
github.com/prebid/prebid-server/v2/adapters/bwx/bwx.go:125:	prepareBidResponse		100.0%
github.com/prebid/prebid-server/v2/adapters/bwx/bwx.go:147:	getMediaTypeForBid		100.0%
total:								(statements)			96.5%

bold-win · 2024-02-15T13:56:19Z

@SyntaxNode done

BoldwinX adapter init

f663567

bold-win mentioned this pull request Jan 26, 2024

BoldwinX adapter docs prebid/prebid.github.io#5105

Merged

1 task

gargcreation1992 assigned gargcreation1992 and onkarvhanumante Jan 29, 2024

SyntaxNode requested changes Jan 30, 2024

View reviewed changes

adapters/bwx/bwx.go Outdated Show resolved Hide resolved

bold-win added 2 commits January 30, 2024 16:38

Merge branch 'prebid:master' into master

e6e6863

Update bwx.go: openrtb 1.9->2.0

2610848

bold-win requested a review from SyntaxNode January 31, 2024 18:18

onkarvhanumante reviewed Feb 2, 2024

View reviewed changes

onkarvhanumante bwx review done

faeadd6

gargcreation1992 reviewed Feb 5, 2024

View reviewed changes

bwx adapter: handle server error using adapters.CheckResponseStatusCo…

9a7baae

…deForErrors

gargcreation1992 previously approved these changes Feb 5, 2024

View reviewed changes

onkarvhanumante previously approved these changes Feb 7, 2024

View reviewed changes

SyntaxNode reviewed Feb 8, 2024

View reviewed changes

bwx: SyntaxNode review

143844c

bold-win dismissed stale reviews from onkarvhanumante and gargcreation1992 via 143844c February 8, 2024 17:32

SyntaxNode reviewed Feb 14, 2024

View reviewed changes

bwx: @SyntaxNode review 2

8da1280

SyntaxNode approved these changes Feb 15, 2024

View reviewed changes

gargcreation1992 approved these changes Feb 19, 2024

View reviewed changes

gargcreation1992 merged commit 8e5a785 into prebid:master Feb 19, 2024
5 checks passed

cross-repo-issue-creation bot mentioned this pull request Feb 19, 2024

Port PR from PBS-Go: New adapter: BoldwinX prebid/prebid-server-java#2993

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

New adapter: BoldwinX #3430

New adapter: BoldwinX #3430

bold-win commented Jan 26, 2024 •

edited

Loading

github-actions bot commented Jan 26, 2024

github-actions bot commented Jan 30, 2024

onkarvhanumante Feb 2, 2024

onkarvhanumante Feb 2, 2024

onkarvhanumante Feb 2, 2024

onkarvhanumante Feb 2, 2024

gargcreation1992 Feb 5, 2024

github-actions bot commented Feb 2, 2024

bold-win commented Feb 2, 2024

gargcreation1992 Feb 5, 2024

bold-win Feb 5, 2024

github-actions bot commented Feb 5, 2024

bold-win commented Feb 6, 2024

bold-win commented Feb 7, 2024 •

edited

Loading

SyntaxNode left a comment

SyntaxNode Feb 8, 2024

SyntaxNode Feb 14, 2024

SyntaxNode Feb 8, 2024

github-actions bot commented Feb 8, 2024

bold-win commented Feb 8, 2024

SyntaxNode left a comment

SyntaxNode Feb 14, 2024

github-actions bot commented Feb 15, 2024

bold-win commented Feb 15, 2024

		@@ -0,0 +1,19 @@
		endpoint: "http://rtb.boldwin.live?pid={{.SourceId}}&host={{.Host}}&pbs=1"

New adapter: BoldwinX #3430

New adapter: BoldwinX #3430

Conversation

bold-win commented Jan 26, 2024 • edited Loading

github-actions bot commented Jan 26, 2024

Code coverage summary

bwx

github-actions bot commented Jan 30, 2024

Code coverage summary

bwx

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

github-actions bot commented Feb 2, 2024

Code coverage summary

bwx

bold-win commented Feb 2, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

github-actions bot commented Feb 5, 2024

Code coverage summary

bwx

bold-win commented Feb 6, 2024

bold-win commented Feb 7, 2024 • edited Loading

SyntaxNode left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

github-actions bot commented Feb 8, 2024

Code coverage summary

bwx

bold-win commented Feb 8, 2024

SyntaxNode left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

github-actions bot commented Feb 15, 2024

Code coverage summary

bwx

bold-win commented Feb 15, 2024

bold-win commented Jan 26, 2024 •

edited

Loading

bold-win commented Feb 7, 2024 •

edited

Loading