Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip coverage tests if more than two adapters were modified #3423

Merged
merged 1 commit into from
Jan 25, 2024

Conversation

onkarvhanumante
Copy link
Contributor

@onkarvhanumante onkarvhanumante commented Jan 23, 2024

PR updates adapter-code-coverage.yml to run coverage tests for max 2 adapter directories

Test details

Coverage tests were skipped for onkarvhanumante#11 PR on forked repo
https://github.com/onkarvhanumante/prebid-server/actions/runs/7628791242/job/20780684209?pr=11

image

@onkarvhanumante onkarvhanumante changed the title Run coverage test for max 2 adapter directories Run adapter coverage test for max 2 adapter directories Jan 23, 2024
@hhhjort
Copy link
Collaborator

hhhjort commented Jan 23, 2024

So if a PR changes more than two adapters, we will not run code coverage tests on it?

@SyntaxNode
Copy link
Contributor

So if a PR changes more than two adapters, we will not run code coverage tests on it?

The goal is to prevent the coverage bot to spam PRs which touch a lot of adapters, like #3387 and #3364. @onkarvhanumante is proposing a cut off of 2 adapters, but I think is open to other suggestions.

@hhhjort
Copy link
Collaborator

hhhjort commented Jan 24, 2024

So if a PR changes more than two adapters, we will not run code coverage tests on it?

The goal is to prevent the coverage bot to spam PRs which touch a lot of adapters, like #3387 and #3364. @onkarvhanumante is proposing a cut off of 2 adapters, but I think is open to other suggestions.

Okay, just wanted to be clear on the expectations. From the title it sounds like it might be intended to. run tests on some adapters, just not all, in the high adapters case.

Copy link
Collaborator

@hhhjort hhhjort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bsardo bsardo changed the title Run adapter coverage test for max 2 adapter directories Skip coverage tests if more than two adapters were modified Jan 25, 2024
@bsardo bsardo merged commit 73b895e into master Jan 25, 2024
3 checks passed
@onkarvhanumante onkarvhanumante deleted the update-coverage-check branch February 15, 2024 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants