Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multiformat fixes #706 #708

Merged
merged 2 commits into from
Nov 2, 2023
Merged

Multiformat fixes #706 #708

merged 2 commits into from
Nov 2, 2023

Conversation

ValentinPostindustria
Copy link
Collaborator

@ValentinPostindustria ValentinPostindustria commented Nov 2, 2023 •
edited
Loading

Closes #706.

  • Fix case when native overwrites other parameters. Add the test covering this case.
  • Fix sizes problem.
  • Fix the wrong adObject parameter value.
  • Make examples more readable.

@ValentinPostindustria
fix: multiformat bugs #706
6a077ed 
 Fix case when native overwrites other parameters. Add test covering this case. Fix sizes.
@ValentinPostindustria ValentinPostindustria marked this pull request as ready for review November 2, 2023 16:11
jsligh
jsligh approved these changes Nov 2, 2023
View reviewed changes
Copy link
Collaborator

@jsligh jsligh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@jsligh jsligh merged commit 9d4faf9 into master Nov 2, 2023
5 checks passed
@jsligh jsligh deleted the feature/multiformat_fixes branch November 2, 2023 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsligh jsligh jsligh approved these changes

@YuriyVelichkoPI YuriyVelichkoPI Awaiting requested review from YuriyVelichkoPI

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Multiformat API bug
2 participants
@ValentinPostindustria @jsligh