Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiformat API bug #706

Closed
ValentinPostindustria opened this issue Nov 2, 2023 · 1 comment · Fixed by #708
Closed

Multiformat API bug #706

ValentinPostindustria opened this issue Nov 2, 2023 · 1 comment · Fixed by #708
Assignees

Comments

@ValentinPostindustria
Copy link
Collaborator

Describe the bug
When we use the new multiformat API with Native parameters it clears banner and video parameters from the request.

To Reproduce
Steps to reproduce the behavior:

  • Run the Demo Kotlin App.
  • Run Multiformat example.
  • Check request with any proxy.

Expected behavior
The request must contain the banner and video parameters.

@ValentinPostindustria ValentinPostindustria self-assigned this Nov 2, 2023
@ValentinPostindustria
Copy link
Collaborator Author

During the fixing, we found another bug.
Steps to reproduce:

    private fun createBannerParameters(): BannerParameters {
        val params = BannerParameters()
        params.adSizes = mutableSetOf(org.prebid.mobile.AdSize(300, 250))
        return params
    }

    private fun createVideoParameters(): VideoParameters {
        val params = VideoParameters(listOf("video/mp4"))
        params.adSize = org.prebid.mobile.AdSize(320, 480)
        return params
    }

The request combines these sizes.

          "banner": {
              "format": [
                  {
                      "h": 480,
                      "w": 320
                  },
                  {
                      "h": 250,
                      "w": 300
                  }
              ]
          },
          "video": {
              "h": 250,
              "w": 300
          }

The banner must contain only the second size, the video must contain another size.

ValentinPostindustria added a commit that referenced this issue Nov 2, 2023
 Fix case when native overwrites other parameters. Add test covering this case. Fix sizes.
ValentinPostindustria added a commit that referenced this issue Nov 2, 2023
 Fix case when native overwrites other parameters. Add test covering this case. Fix sizes.
jsligh added a commit that referenced this issue Nov 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant