Issue 40: Refactor/cleanup metadata layer #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andrew Robertson <[email protected]>
Signed-off-by: Andrew Robertson <[email protected]>
Signed-off-by: Andrew Robertson <[email protected]>
Signed-off-by: Andrew Robertson <[email protected]>
Signed-off-by: Andrew Robertson <[email protected]>
Signed-off-by: Andrew Robertson <[email protected]>
Signed-off-by: Andrew Robertson <[email protected]>
Signed-off-by: Andrew Robertson <[email protected]>
Signed-off-by: Andrew Robertson <[email protected]>
Signed-off-by: Andrew Robertson <[email protected]>
Signed-off-by: Andrew Robertson <[email protected]>
Signed-off-by: Andrew Robertson <[email protected]>
Signed-off-by: Andrew Robertson <[email protected]>
Signed-off-by: Andrew Robertson <[email protected]>
Signed-off-by: Andrew Robertson <[email protected]>
Signed-off-by: Andrew Robertson <[email protected]>
Signed-off-by: Andrew Robertson <[email protected]>
Signed-off-by: Andrew Robertson <[email protected]>
Signed-off-by: Andrew Robertson <[email protected]>
Signed-off-by: Andrew Robertson <[email protected]>
Signed-off-by: Andrew Robertson <[email protected]>
…che for test. Signed-off-by: Andrew Robertson <[email protected]>
Signed-off-by: Andrew Robertson <[email protected]>
Signed-off-by: Andrew Robertson <[email protected]>
Signed-off-by: Andrew Robertson <[email protected]>
karansinghneu
approved these changes
Sep 7, 2021
chipmaurer
approved these changes
Sep 7, 2021
fpj
requested changes
Sep 10, 2021
src/main/java/io/pravega/connectors/presto/PravegaConnectorConfig.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Andrew Robertson <[email protected]>
@fpj they are in prestodb git. specifically they are based on the files here: https://github.com/prestodb/presto/tree/master/presto-kafka/src/test/resources/tpch there is no license in the source files as can't have comments in json. we have a general attribution to Presto already in our NOTICE file |
Signed-off-by: Andrew Robertson <[email protected]>
Signed-off-by: Andrew Robertson <[email protected]>
Signed-off-by: Andrew Robertson <[email protected]>
Signed-off-by: Andrew Robertson <[email protected]>
Signed-off-by: Andrew Robertson <[email protected]>
Signed-off-by: Andrew Robertson <[email protected]>
fpj
requested changes
Sep 28, 2021
prestodb/src/main/java/io/pravega/connectors/presto/util/PravegaNameUtils.java
Show resolved
Hide resolved
prestodb/src/test/java/io/pravega/connectors/presto/util/MockSchemaRegistryClient.java
Show resolved
Hide resolved
prestodb/src/test/java/io/pravega/connectors/presto/util/MockStreamManager.java
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #40
Simplifies metadata layer (PravegaTableDescriptionSupplier)