Issue 10: extendeds3 move #17
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sachin-j-joshi
requested changes
Sep 1, 2020
|
Yes Sachin I did |
sachin-j-joshi
requested changes
Sep 3, 2020
ravibeta
force-pushed
the
issue-10-extendeds3-move
branch
from
8c5586b
to
39f6597
Compare
|
Yes Sachin I did |
ravibeta
force-pushed
the
issue-10-extendeds3-move
branch
from
e43dee1
to
3bac105
Compare
Codecov Report
@@ Coverage Diff @@
## feature-separate-adapters #17 +/- ##
===============================================================
+ Coverage 72.77% 77.76% +4.98%
- Complexity 95 187 +92
===============================================================
Files 10 18 +8
Lines 518 949 +431
Branches 47 92 +45
===============================================================
+ Hits 377 738 +361
- Misses 102 148 +46
- Partials 39 63 +24
Continue to review full report at Codecov.
|
added 2 commits
September 15, 2020 11:41
Signed-off-by: Ravi Rajamani <[email protected]>
Signed-off-by: Ravi Rajamani <[email protected]>
ravibeta
force-pushed
the
issue-10-extendeds3-move
branch
from
ca82d6b
to
cbe63e6
Compare
sachin-j-joshi
requested changes
Sep 18, 2020
There was a problem hiding this comment.
https://github.com/ravibeta/pravega-storage-adapters-1/tree/issue-10-extendeds3-move/extendeds3/src/test/java/io/pravega/test still shows BookKeeperIntegrationTestBase.java
| @@ -0,0 +1,23 @@ | |||
| <?xml version="1.0" encoding="UTF-8"?> | |||
There was a problem hiding this comment.
Is this file at the right place?
| @@ -0,0 +1,22 @@ | |||
| <?xml version="1.0" encoding="UTF-8"?> | |||
There was a problem hiding this comment.
Is this file at the right place?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change log description
This change is for separation of Pravega bindings from the main source so that they can be maintained independently. It brings extendeds3 to the repository with commit history from both master and setup-repository branch
All the changes similar to hdfs have been made
Purpose of the change
Fixes #10
What the code does
It builds, tests and publishes the extendeds3 binding separately so that they can be included with Pravega as a long-term-storage adapter.
How to verify it
This works with Pravega in all forms of deployment.
https://travis-ci.com/github/ravibeta/pravega-storage-adapters-1/builds/184454484