Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose reader positions #465

Merged
merged 12 commits into from
Feb 23, 2024
Merged

Conversation

ShwethaSNayak
Copy link
Contributor

@ShwethaSNayak ShwethaSNayak commented Feb 9, 2024

Change log description
Expose Streamcut API for rust client. Streamcut represent stream to readers position in that stream segment.

Purpose of the change
Closes #466, #411

What the code does

  • Add API get_streamcut() which returns StreamCut object.
  • User is expected to call reader_group.get_streamcut() api periodically to get current streamcuts and use them while creating ReaderGroup.
  • Stream cuts information's gets updated for every 3 sec interval.

How to verify it
Existing tests should pass

Signed-off-by: Shwetha N <[email protected]>
@ShwethaSNayak ShwethaSNayak marked this pull request as draft February 9, 2024 09:53
Signed-off-by: Shwetha N <[email protected]>
@ShwethaSNayak ShwethaSNayak marked this pull request as ready for review February 15, 2024 07:31
Copy link

codecov bot commented Feb 15, 2024

Codecov Report

Attention: Patch coverage is 48.64865% with 19 lines in your changes are missing coverage. Please review.

Project coverage is 72.68%. Comparing base (f4e8244) to head (c99b0a6).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #465      +/-   ##
==========================================
+ Coverage   64.44%   72.68%   +8.24%     
==========================================
  Files          49       50       +1     
  Lines       11810    12464     +654     
  Branches    11810    12464     +654     
==========================================
+ Hits         7611     9060    +1449     
+ Misses       4199     3404     -795     
Files Coverage Δ
src/event/reader_group.rs 94.79% <100.00%> (ø)
src/event/reader_group_state.rs 89.74% <ø> (+0.09%) ⬆️
src/event/reader.rs 71.50% <47.22%> (-0.76%) ⬇️

... and 12 files with indirect coverage changes

@tkaitchuck tkaitchuck merged commit 4778dc5 into pravega:master Feb 23, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ReaderGroup does not expose StreamCut
2 participants