Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update python bindings instructions #451

Closed
wants to merge 3 commits into from
Closed

Conversation

gfinol
Copy link

@gfinol gfinol commented Oct 17, 2023

Change log description
Updates the instructions to create Python bindings to maturin 0.14.

Purpose of the change
Fixes #450.

What the code does
Updated the README instructions.

How to verify it
Follow the updated steps in the README to create the bindings.

Signed-off-by: Gerard Finol <[email protected]>
@codecov-commenter
Copy link

Codecov Report

Merging #451 (a26ca0c) into master (3a9434f) will increase coverage by 0.04%.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #451      +/-   ##
==========================================
+ Coverage   72.74%   72.78%   +0.04%     
==========================================
  Files          48       49       +1     
  Lines       12345    12390      +45     
  Branches    12345    12390      +45     
==========================================
+ Hits         8980     9018      +38     
- Misses       3365     3372       +7     

see 16 files with indirect coverage changes

@RaulGracia
Copy link

@tkaitchuck @vangork guys, can you please give a closure to this PR? Thanks!

@anishakj
Copy link
Contributor

anishakj commented Dec 8, 2023

@gfinol Could you please move this PR to the new repo, https://github.com/pravega/pravega-client-python

Copy link
Member

@tkaitchuck tkaitchuck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Please fix pre-submit check

@gfinol
Copy link
Author

gfinol commented Jan 8, 2024

@anishakj PR moved to the new repo: pravega/pravega-client-python#14

cc @tkaitchuck

@tkaitchuck tkaitchuck closed this Jan 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Python Bindings instructions are outdated
5 participants