-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reorg builtins #1847
Reorg builtins #1847
Conversation
jit-compiler/src/compiler.rs
Outdated
@@ -60,6 +59,23 @@ pub fn generate_glue_code<T: FieldElement>( | |||
Ok(format!("{PREAMBLE}\n{glue}\n",)) | |||
} | |||
|
|||
const PREAMBLE: &str = r#" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
will remove, this is from another pr
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't used ibig::Ibig before, just wondering why you prefer this over others, does this have a better performance?
We use it in |
BUILTINS.get_or_init(|| { | ||
[ | ||
( | ||
"std::array::len", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is std::convert::fe
missing on purpose?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It was not working as it was written any way. Will be re-added in #1834
No description provided.