fix publics bug halo2 #1814
Open
fix publics bug halo2 #1814
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leonardoalt
force-pushed
the
publics-bug
branch
from
3d15455
to
7d22174
Compare
|
I'm confused about this:
|
|
Can you add a test for the example in the documentation? |
It only fails for the public case, my assumption is no tests with publics + halo2 proofs?
It somehow changes the verification key. I don't know if the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bug where circuits with publics can't be verified properly. This was caused by a difference in the circuit when the verification key is generated (without witnesses) vs when the user requests a proof (with).