Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make machine statements compatible with block statements. #1768

Closed
wants to merge 7 commits into from
Closed

Make machine statements compatible with block statements. #1768

wants to merge 7 commits into from

Conversation

chriseth
Copy link
Member

@chriseth chriseth commented Sep 9, 2024

No description provided.

@chriseth chriseth changed the title Turn machine statements into block statements. Make machine statements compatible with block statements. Sep 9, 2024
gzanitti
gzanitti previously approved these changes Sep 9, 2024
View reviewed changes
@chriseth chriseth marked this pull request as draft September 12, 2024 08:20
@chriseth chriseth marked this pull request as ready for review September 23, 2024 14:51
lvella
lvella reviewed Sep 30, 2024
View reviewed changes
Copy link
Member

@lvella lvella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why in some let you set the type to col, and others you leave the type unspecified?

Should I use just let instead of col witness?

@chriseth
Copy link
Member Author

This is just a partial PR, I didn't want to make it gigantic. In the future, please use let instead of col witness.

@chriseth
Copy link
Member Author

Ah forget it.

@chriseth chriseth closed this Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lvella lvella lvella left review comments

@gzanitti gzanitti gzanitti left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chriseth @lvella @gzanitti