Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use Rotation::prev() instead of Rotation(degree) #1681

Closed
wants to merge 1 commit into from
Closed

use Rotation::prev() instead of Rotation(degree) #1681

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion backend/src/composite/split.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ pub(crate) fn split_pil<F: FieldElement>(pil: &Analyzed<F>) -> BTreeMap<String,
.collect()
}

/// Given a set of columns and a PIL describing the machine, returns the witness column that belong to the machine.
/// Given a set of columns and a PIL describing the machine, returns the witness columns that belong to the machine.
/// Note that this also adds the dummy column.
pub(crate) fn machine_witness_columns<F: FieldElement>(
all_witness_columns: &[(String, Vec<F>)],
Expand Down
5 changes: 1 addition & 4 deletions backend/src/halo2/circuit_builder.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -271,10 +271,7 @@ impl<'a, T: FieldElement, F: PrimeField<Repr = [u8; 32]>> Circuit<F> for PowdrCi
.keys()
.map(|name| {
let first_row = meta.query_advice(config.advice[name], Rotation::cur());
let last_row = meta.query_advice(
config.advice[name],
Rotation(analyzed.degree().try_into().unwrap()),
);
let last_row = meta.query_advice(config.advice[name], Rotation::prev());
let expr = first_step.clone() * (first_row - last_row);
(format!("enforce wrapping ({name})"), expr)
})
Expand Down
Loading