Plonky public values constrained by fixed columns #1610
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Schaeff
reviewed
Jul 25, 2024
ast/src/analyzed/mod.rs
Outdated
| .public_declarations | ||
| .values() | ||
| .map(|public_declaration| { | ||
| let witness_name = public_declaration.referenced_poly_name(); |
There was a problem hiding this comment.
This does not have to be a witness, public inputs can reference any column (even if it doesn't make sense in practice to expose a cell of a fixed column)
There was a problem hiding this comment.
probably column makes more sense in this block
Schaeff
reviewed
Jul 26, 2024
Schaeff
reviewed
Aug 1, 2024
Schaeff
approved these changes
Aug 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressing #1607 -- changing the implementation for constraining public values to reflect changes from #1543, as well as a slight refactoring of PowdrCircuit struct to include publics.