Add test using a bus in each machine #1605
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leonardoalt
previously approved these changes
Jul 25, 2024
|
Looks like this test never completed, because I tested with PILCOM, which doesn't support challenge (and apparently just doesn't complete?). After I fixed it, I also had to add a dummy witness column so that Halo2 doesn't complain. |
leonardoalt
approved these changes
Jul 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I started this in order to test #1603. However, due to #1604, currently only one machine has a bus so far. This should be fixed as part of #1604.
Then, what we would expect is that both machines have the same final accumulator values, assuming challenges are shared across machines.