Fixed cols in functions #1545
Fixed cols in functions #1545
Conversation
chriseth
force-pushed
the
fixed_cols_in_functions
branch
from
019c570
to
53f3d76
Compare
chriseth
force-pushed
the
fixed_cols_in_functions
branch
from
9e052ff
to
dd3b250
Compare
chriseth
force-pushed
the
fixed_cols_in_functions
branch
from
ab28754
to
0e6af5c
Compare
| "#; | ||
| let output = asm_string_to_pil::<GoldilocksField>(input).to_string(); | ||
| let expected = " 2 = 0;\n"; | ||
| assert_eq!(output, expected); |
There was a problem hiding this comment.
Maybe this test should be moved to one of the compiler crates instead of Pipeline which does end-to-end stuff?
There was a problem hiding this comment.
We don't have a crate that spans asm and pil, so pipeline is the correct crate IMO
pil-analyzer/tests/types.rs
Outdated
| "; | ||
| type_check(input, &[]); | ||
| } | ||
| // TODO also check type vars used in types and also check this all for asm code. |
| (None, Some(value)) => self.infer_type_of_expression(value)?, | ||
| (Some(ty), None) => { | ||
| if *ty != Type::Col { | ||
| // TODO better source ref |
| (Some(ty), None) => { | ||
| if *ty != Type::Col { | ||
| // TODO better source ref | ||
| return Err(source_ref.with_error("Let-declared variables without value must have type 'col'.".to_string())); |
There was a problem hiding this comment.
is there a test that reaches this?
There was a problem hiding this comment.
where? I don't see a diff from my latest review
| type_scheme: None, | ||
| })) | ||
| } else { | ||
| Err(EvalError::TypeError(format!("Only lambda expressions are allowed for dynamically-created fixed columns. Got {v}."))) |
There was a problem hiding this comment.
Is there a test that reaches this?
There was a problem hiding this comment.
I don't think so, it should not be able to pass the type checker.
There was a problem hiding this comment.
Should I change this here to panic?
|
It seems that the type inference algorithm does not assign types to local variables (i.e. it does not modify the ast there). I think it should. Will add that. |
No description provided.