Run Halo2 MockProver even when POWDR_GENERATE_PROOFS=false (#1629)

This is similar to how we always run PILCOM in the Goldilocks setting, and shouldn't be expensive!
powdr-labs · Aug 13, 2024 · 2b9984c · 2b9984c
1 parent 6637bba
commit 2b9984c
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/.github/workflows/nightly-tests.yml b/.github/workflows/nightly-tests.yml
@@ -7,6 +7,7 @@ on:
 env:
     CARGO_TERM_COLOR: always
     IS_NIGHTLY_TEST: true
+    POWDR_GENERATE_PROOFS: "true"
 
 jobs:
   check_if_needs_running:

diff --git a/pipeline/src/test_util.rs b/pipeline/src/test_util.rs
@@ -173,10 +173,8 @@ pub fn gen_estark_proof_with_backend_variant(
 }
 
 pub fn test_halo2(pipeline: Pipeline<Bn254Field>) {
-    if should_generate_proofs() {
-        test_halo2_with_backend_variant(pipeline.clone(), BackendVariant::Monolithic);
-        test_halo2_with_backend_variant(pipeline, BackendVariant::Composite);
-    }
+    test_halo2_with_backend_variant(pipeline.clone(), BackendVariant::Monolithic);
+    test_halo2_with_backend_variant(pipeline, BackendVariant::Composite);
 }
 
 /// Whether to compute a monolithic or composite proof.
@@ -207,7 +205,8 @@ pub fn test_halo2_with_backend_variant(
     let is_nightly_test = env::var("IS_NIGHTLY_TEST")
         .map(|v| v == "true")
         .unwrap_or(false);
-    if is_nightly_test {
+
+    if is_nightly_test && should_generate_proofs() {
         gen_halo2_proof(pipeline, backend_variant);
     }
 }