Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: multi-platform Docker images #3029

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

bripkens
Copy link

Why

More and more systems are running on the arm64 platform. For example, AWS EC2 instances with Graviton2 processors or ARM-based MacBooks. One of our customers is facing issues, because Newman does not run on ARM-based systems. More specifically, the postman/newman Docker image only supports the linux/amd64 platform.

What

This change enables the creation of linux/amd64 and linux/arm64 Docker images.

The change also removes the Docker image definition for Ubuntu 14.04 and Alpine 3.3. Both of these newman Docker images haven't been published in two years and can therefore be removed.

Trial Run

Here are the generated Docker images and tags for the latest newman version across for the
develop and master branch.

develop branch:

  • alpine
    • postman/newman:5.3.2-alpine
    • postman/newman:5.3-alpine
    • postman/newman:5-alpine
  • ubuntu
    • postman/newman:5.3.2-ubuntu
    • postman/newman:5.3-ubuntu
    • postman/newman:5-ubuntu

master branch:

  • alpine
    • postman/newman:alpine
    • postman/newman:latest
    • postman/newman:5.3.2
    • postman/newman:5.3
    • postman/newman:5
    • postman/newman:5.3.2-alpine
    • postman/newman:5.3-alpine
    • postman/newman:5-alpine
  • ubuntu
    • postman/newman:ubuntu
    • postman/newman:5.3.2-ubuntu
    • postman/newman:5.3-ubuntu
    • postman/newman:5-ubuntu

# Why

More and more systems are running on the arm64 platform. For example,
AWS EC2 instances with Graviton2 processors or ARM-based MacBooks.
One of our customers is facing issues, because Newman does not run
on ARM-based systems. More specifically, the `postman/newman` Docker
image only supports the `linux/amd64` platform.

# What

This change enables the creation of `linux/amd64` and
`linux/arm64` Docker images.

The change also removes the Docker image definition for Ubuntu 14.04 and
Alpine 3.3. Both of these newman Docker images haven't been published in
two years and can therefore be removed.
@codecov
Copy link

codecov bot commented Oct 21, 2022

Codecov Report

Merging #3029 (dd65736) into develop (5e0e9b7) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop    #3029   +/-   ##
========================================
  Coverage    90.96%   90.96%           
========================================
  Files           21       21           
  Lines         1151     1151           
  Branches       349      349           
========================================
  Hits          1047     1047           
  Misses         104      104           
Flag Coverage Δ
cli 82.18% <ø> (ø)
integration 42.31% <ø> (+1.30%) ⬆️
library 58.55% <ø> (ø)
unit 75.06% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@ypoplavs
Copy link

Hello,
We also need ARM-support for postman/newman Docker image. Are there any updates on it?

@jaredtbates
Copy link

We're running into this too.

@edouard-lopez
Copy link

We are deploying Testkube internally, and we are running on this issue too. Latest postman/newman tag is 2 years old and only AMD64 :S
What is blocking this MR to move forward?

@@ -1,7 +1,7 @@
FROM ubuntu:18.04
LABEL maintainer="Postman Labs <[email protected]>"

ARG NODE_VERSION=10
ARG NODE_VERSION=16
Copy link

@edouard-lopez edouard-lopez Nov 2, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that this PR is about a year old. I no longer have a need for these changes and will therefore not work on this PR anymore. Feel free to pick up on this state.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants