Clean up failed releases #546
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DavisVaughan
approved these changes
Sep 26, 2024
| name: Clean up Failed Releases | ||
| if: ${{ failure() }} | ||
| runs-on: ubuntu-latest | ||
| needs: [upload_release_binaries, get_version] |
There was a problem hiding this comment.
Suggested change
| needs: [upload_release_binaries, get_version] | |
| needs: [upload_release_binaries] |
Is there any reason not to just do this?
There was a problem hiding this comment.
Oh I guess that gives us needs.get_version.outputs.ARK_VERSION?
.github/workflows/release.yml
Outdated
Comment on lines
187
to
197
| - name: Delete failed release if any | ||
| env: | ||
| GH_TOKEN: ${{ github.token }} | ||
| run: | | ||
| TAG=${{ needs.get_version.outputs.ARK_VERSION }} | ||
| if gh release view $TAG > /dev/null 2>&1; then | ||
| echo "Cleaning up release $TAG" | ||
| gh release delete $TAG -y --cleanup-tag | ||
| else | ||
| echo "No release to clean up" | ||
| fi |
There was a problem hiding this comment.
Rather than gh release view should we just use the same "release exists" action from above? (it needs to be updated too, but the consistency feels nice)
- name: Check for existing release tag
uses: mukunku/[email protected]
id: check_tag
with:
tag: ${{ needs.get_version.outputs.ARK_VERSION }}
There was a problem hiding this comment.
Done, and I've updated the action
lionel-
force-pushed
the
feature/release-cleanup
branch
4 times, most recently
from
8bffef9
to
7582bb5
Compare
lionel-
force-pushed
the
feature/release-cleanup
branch
from
7582bb5
to
0f56d85
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's currently possible for our workflows to leave a new release in a failed or incomplete state:
To avoid this, we now clean up releases in case of propagated failure.
Another change made here is that the Slack failure report will now also be sent if an upload-release step fails. Previously we would only report build failures.
Making sure we don't create partial releases should help with posit-dev/positron#4815.
Approach: This uses the
ghCLI tool to check for existence of a release and delete it if any.