scripts/ci: When building a package, add corresponding staging repo #1197
Conversation
This way a package can build against an unreleased dynamic library (for instance) if both are in branches with the same name.
ids1024
force-pushed
the
sbuild-staging-repos
branch
from
8824fb2
to
b99d810
Compare
| "--no-apt-distupgrade", | ||
| ] | ||
|
|
||
| for (repo, _) in pockets: |
There was a problem hiding this comment.
My main concern here is what might be in pockets, and the fact that this potentially adds multiple additional repositories. If I understand, if the same commit is pushed to multiple branches, the CI will use the same build. I'm not sure if the dependencies it adds here might then cause possible problems...
There was a problem hiding this comment.
All you really need is to add the branch the package is being built from, so if building for focal on branch new-feature, you'd add http://apt.pop-os.org/staging/new-release focal main.
There was a problem hiding this comment.
My understanding is that in the (unlikely) case that the same commit is pushed to two branches between CI runs, pockets will contain both branches, and the same build will be used for both. If another branch is later updated to a commit that already has a build for another branch (for instance, a fast-forward merge), the package will be copied without rebuilding.
That's why this requires a loop and potentially could add multiple branches. But I'm happy to be corrected.
This way a package can build against an unreleased dynamic library (for instance) if both are in branches with the same name.
Some resolution to this is needed for https://github.com/pop-os/gnome-control-center/tree/pop-keyboard_focal to be able build with a dependency on keyboard-backlight. Opening as a draft because I'm not sure this is a good idea...