Support glow with sctk using updated version of iced_glutin #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit f1ada7a. Fixes panic when using lazy widgets
feat: various improvements to window commands and event handling
…hey have been handled in the event loop
feat: sent output events
* sctk: Don't send output events twice With these lines, a subscription seems to receive output events twice. Without it, only once as expected. * sctk: Make `IcedOutput::Output` take a `WlOutput` This is the most flexible solution, and using output events, it is possible to create surfaces for specific outputs or all. Matching by make/model is a bad idea anyway. Matching by name may be appropriate.
…aces, and also adds the option for starting with no initial surface
For some reason this was an issue testing with `iced_glow`/`glutin`, but this also fixes the issue I was having where the application doesn't get output events if I destroy the initial surface and create surfaces later.
This provides a `Compositor` adapting a `GLCompositor`, that thus can be used with `iced_winit` or with a different shell. Backport of iced-rs#1688. Still needs some work.
Fixes behavior with `InitialSurface::None`.
wash2
force-pushed
the
master
branch
2 times, most recently
from
33b2fd9
to
56b6d65
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on iced-rs#1688, which still may need improvements to config handling and errors but mostly works.
Still need to test this with libcosmic, and support this in dyrend.