Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(wgpu): invisible windows on X11 desktops with dGPU+iGPU #157

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

@mmstick mmstick requested a review from a team July 6, 2024 20:32
Copy link
Member

@Drakulix Drakulix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, it would kinda be cleaner to read out the drm-device used by the xserver via dri, similar to how we handle the wayland case.

That way we don't make any assumptions, which gpu is used as the main gpu depending on the chassis type.

I could imagine this could cause similar issues otherwise when explicitly selecting discrete-mode on our laptops.

@Drakulix
Copy link
Member

Drakulix commented Jul 6, 2024

We could easily borrow some code from smithay to do that: https://github.com/Smithay/smithay/blob/master/src/backend/x11/mod.rs (mainly egl_init and dri3_init).

(Though we would want to use x11rb's xcb feature to use the raw pointers from the wgpu surface.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cosmic-store crashing when launching - X11
2 participants