Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pool 2870 update prizepool vault to be able to redistribute prizes #14

Merged
merged 5 commits into from
Jul 4, 2023
Merged

Pool 2870 update prizepool vault to be able to redistribute prizes #14

merged 5 commits into from
Jul 4, 2023

Conversation

asselstine
Copy link
Contributor

No description provided.

@linear
Copy link

linear bot commented Jun 28, 2023

POOL-2870 Update PrizePool + Vault to be able to redistribute prizes

  • PrizePool claimPrize should be singular and take a single winner / prize index / recipient
  • Vault should allow winners to have a before and after prize hook

@asselstine
Copy link
Contributor Author

Note: compilation was having trouble so I also removed the dependency on the claimer

@github-actions
Copy link

LCOV of commit d19b0a1 during coverage #131

Summary coverage rate:
  lines......: 100.0% (184 of 184 lines)
  functions..: 100.0% (63 of 63 functions)
  branches...: no data found

Files changed coverage rate:
                      |Lines       |Functions  |Branches    
  Filename            |Rate     Num|Rate    Num|Rate     Num
  ==========================================================
  src/Vault.sol       | 100%    178| 100%    61|    -      0
  src/VaultFactory.sol| 100%      6| 100%     2|    -      0

trmid
trmid suggested changes Jul 4, 2023
View reviewed changes
Copy link
Contributor

@trmid trmid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some suggestions for name changes on the hook struct to make it less repetitive.

src/interfaces/IVaultHooks.sol Outdated Show resolved Hide resolved
src/Vault.sol Outdated Show resolved Hide resolved
@trmid trmid merged commit 3233eb8 into main Jul 4, 2023
0 of 2 checks passed
@trmid trmid deleted the pool-2870-update-prizepool-vault-to-be-able-to-redistribute-prizes branch July 4, 2023 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trmid trmid trmid approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@asselstine @trmid