-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Draw State Terminology #41
Conversation
LCOV of commit
|
src/PrizePool.sol
Outdated
/// @notice Returns the start time of the draw for the next successful completeAndStartNextDraw | ||
function _nextDrawStartsAt() internal view returns (uint64) { | ||
return _nextDrawEndsAt() - drawPeriodSeconds; | ||
/// @notice Returns the start time of the draw for the next successful closeAndStartNextDraw |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be transitionDraws
.
src/PrizePool.sol
Outdated
uint256 winningRandomNumber_ | ||
) external onlyDrawManager returns (uint16) { | ||
/// @return The ID of the closed draw | ||
function transitionDraws(uint256 winningRandomNumber_) external onlyDrawManager returns (uint16) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure we should convey that this function also starts the next Draw, it's kinda implied.
I feel like completeDraw
or awardDraw
would be enough.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah I originally changed it to just closeDraw
but I figured I should retain the message that was conveyed by the old name. I'll change it back to closeDraw
.
LCOV of commit
|
Updates the language around the state of draws to be "Closed" and "Open" rather than "Completed" and "Next". The "current" draw is open, all others are closed. When we close the open draw and open the next, we "transition" draws.