Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary lines from remappings.txt #2

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

BlinkyStitt
Copy link

I'm trying to include ring-buffer-lib and the twab-controller repos in my code, but with these two lines my code breaks because its trying to load everything from inside ring-buffer-lib.

Error (6275): Source "lib/ring-buffer-lib/src/YearnVaultV3.sol" not found: File not found. Searched the following locations: "/Users/bryan/code/alderson-dice/foundry".
ParserError: Source "lib/ring-buffer-lib/src/YearnVaultV3.sol" not found: File not found. Searched the following locations: "/Users/bryan/code/alderson-dice/foundry".
 --> test/GameToken.t.sol:6:1:
  |
6 | import {YearnVaultV3, YearnVaultV3Strategy} from "../src/YearnVaultV3.sol";
  | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

I ran forge remappings in this repo and it didn't write these lines for me, so I'm not sure why they are here.

Maybe forge should be smarter about this and we should open an issue there. but just removing these lines got things working for me

I'm trying to include ring-buffer-lib and the twab-controller repos in my code, but with these two lines my code breaks because its trying to load everything from inside ring-buffer-lib.

```
Error (6275): Source "lib/ring-buffer-lib/src/YearnVaultV3.sol" not found: File not found. Searched the following locations: "/Users/bryan/code/alderson-dice/foundry".
ParserError: Source "lib/ring-buffer-lib/src/YearnVaultV3.sol" not found: File not found. Searched the following locations: "/Users/bryan/code/alderson-dice/foundry".
 --> test/GameToken.t.sol:6:1:
  |
6 | import {YearnVaultV3, YearnVaultV3Strategy} from "../src/YearnVaultV3.sol";
  | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
``` 

I ran `forge remappings` in this repo and it didn't write these lines for me, so I'm not sure why they are here.

Maybe `forge` should be smarter about this and we should open an issue there. but just removing these lines got things working for me
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant