TS Wraps support #1888
Merged
TS Wraps support #1888
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
namesty
requested review from
dOrgJelli,
krisbitney,
nerfZael,
Niraj-Kamdar and
cbrzn
as code owners
dOrgJelli
requested changes
Sep 6, 2023
packages/test-cases/cases/cli/build-cmd/wasm/typescript/001-sanity/polywrap.yaml
Outdated
Show resolved
Hide resolved
packages/test-cases/cases/cli/build-cmd/wasm/typescript/001-sanity/polywrap.build.yaml
Outdated
Show resolved
Hide resolved
| @@ -0,0 +1 @@ | |||
| 0.1.6 | |||
There was a problem hiding this comment.
NIT: strange that we started this off at 0.1.6
There was a problem hiding this comment.
Yeah, the image I published has no version tag. Just initted this with 0.0.1
There was a problem hiding this comment.
@namesty it looks like you might have accidentally published 0.1.6, see here: https://hub.docker.com/r/polywrap/vm-base-js/tags
Not sure if we can "yank" the tag or not. Also let's start dev versioning at 0.1.0 like we do in our other software.
packages/cli/src/lib/defaults/build-strategies/wasm/javascript/vm/Dockerfile
Show resolved
Hide resolved
packages/cli/src/lib/defaults/build-strategies/wasm/javascript/local/local.sh
Outdated
Show resolved
Hide resolved
packages/cli/src/lib/build-strategies/strategies/DockerVMStrategy.ts
Outdated
Show resolved
Hide resolved
packages/cli/src/lib/build-strategies/strategies/DockerVMStrategy.ts
Outdated
Show resolved
Hide resolved
dOrgJelli
reviewed
Sep 7, 2023
| @@ -0,0 +1,3 @@ | |||
| format: 0.3.0 | |||
| config: | |||
| scriptFile: ./bundled/wrap.js | |||
dOrgJelli
approved these changes
Sep 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds:
Creating TS wrap projects
Codegen for TS wrap bindings
Template for TS wrap projects
Building TS wraps with Image and VM strategies
Additionally, it separates binding languages from build languages: go, rust and assemblyscript are both; interfaces and typescript are bindings only and javascript is, currently, build only.
The reason for this is that we shouldn't need 2 different directories for JS and TS build strategies; because TS wraps are TS bindings + rollup.js config that produce a single JS file, that is then built as a JS wrap.
The reasons I built it this way are basically letting users tweak bundling configurations and debug their bundles freely, or even use other bundlers like webpack; and in general, not doing anything special or extra on our side for TS, but rather trying to get it as cheaply as possible on top of JS wraps