Implement divide money expressions #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* New MissingExchangeRateException * Default Bank also throws this exception now * More specific tests for Evaluation added * Documented decision for division of different currencies * Dummy implementation (red) * Make it compile (types)
* Allow a context for Divide.
FreeApophis
force-pushed
the
implement-divide-money-expressions
branch
from
6eee502
to
8f55909
Compare
Mafii
requested changes
Aug 21, 2023
FreeApophis
force-pushed
the
implement-divide-money-expressions
branch
from
fdceb64
to
7e90982
Compare
Mafii
reviewed
Aug 21, 2023
Mafii
approved these changes
Aug 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows to calculate factors between two Money objects.