Fix upload section adding deleted images to the canvas #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
👷 Deploy request for polotno-studio pending review.Visit the deploys page to approve it
|
MichaelDimmitt
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #46
Happy to make changes.
The more correct solution to this would be event.stopPropogation.
However, that information would need to be enabled on
ImagesGridfrom 'polotno/side-panel'; Which I do not think is source available.To see the change in action look at commit: 4384c3d
Originally the upload section was commented out so I put a commit on top commenting it back out.
Issue:
upload-section adds an image to the canvas when deleting.
Expected:
Image should be deleted and no image added to the canvas.
Steps to reproduce:
Uncommenting the following line in App.js:
DEFAULT_SECTIONS.unshift(UploadSection);add
import {UploadSection} from './sections/upload-section'to the top of App.jsVideo of issue: (deleted image is added to the canvas)
delete-incorrectly-loads-image.mov
Video with solution: (deleted image does not get added to the canvas)
fixed.mov
Cheers,
Michael Dimmitt