Hello @lavrton, #30
Open
Hello @lavrton, #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Please review my pull request. I've added a "Save File" button with the option to customize the file name. I found that every time we save a file in Polotno Studio, it's automatically named "polotno.json." I've worked on changing this behavior to allow for custom file names. Your feedback on this change is greatly appreciated. Thank you for your time and assistance!
👷 Deploy request for polotno-studio pending review.Visit the deploys page to approve it
|
|
Hello. That is a good request. But what if we will generate filename based on the content, like we do for image saving? https://github.com/polotno-project/polotno-studio/blob/master/src/topbar/download-button.js#L23-L34 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please review my pull request. I've added a "Save File" button with the option to customize the file name. I found that every time we save a file in Polotno Studio, it's automatically named "polotno.json." I've worked on changing this behavior to allow for custom file names. Your feedback on this change is greatly appreciated.
Thank you for your time and assistance!