refactor(rust): Add pre-filtered decode to new parquet source #18715
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
internal
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #18715 +/- ##
==========================================
- Coverage 79.90% 79.81% -0.10%
==========================================
Files 1513 1513
Lines 203465 203663 +198
Branches 2892 2892
==========================================
- Hits 162579 162551 -28
- Misses 40338 40564 +226
Partials 548 548 ☔ View full report in Codecov by Sentry. |
nameexhaustion
force-pushed
the
pqs-prefilter
branch
from
b599e78
to
325c253
Compare
nameexhaustion
force-pushed
the
pqs-prefilter
branch
from
325c253
to
02cca62
Compare
nameexhaustion
commented
Sep 12, 2024
nameexhaustion
requested review from
ritchie46,
orlp and
c-peters
as code owners
nameexhaustion
force-pushed
the
pqs-prefilter
branch
from
fe8ccc1
to
4bd8274
Compare
nameexhaustion
commented
Sep 12, 2024
| @@ -287,12 +288,69 @@ impl ParquetSourceNode { | |||
| let ideal_morsel_size = get_ideal_morsel_size(); | |||
| let min_values_per_thread = self.config.min_values_per_thread; | |||
|
|
|||
| let use_prefiltered = physical_predicate.is_some() | |||
| let mut use_prefiltered = physical_predicate.is_some() | |||
| && matches!( | |||
| self.options.parallel, | |||
| ParallelStrategy::Auto | ParallelStrategy::Prefiltered | |||
There was a problem hiding this comment.
This currently enables pre-filtering by default on new-streaming
ritchie46
approved these changes
Sep 13, 2024
nameexhaustion
added a commit
to nameexhaustion/polars
that referenced
this pull request
Sep 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.