Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Don't raise on multiple same names in ie_join #18658

Merged
merged 1 commit into from
Sep 10, 2024
Merged

chore: Don't raise on multiple same names in ie_join #18658

merged 1 commit into from
Sep 10, 2024

Conversation

ritchie46
Copy link
Member

No description provided.

@github-actions github-actions bot added internal An internal refactor or improvement python Related to Python Polars rust Related to Rust Polars labels Sep 10, 2024
@ritchie46
Copy link
Member Author

@coastalwhite fyi

@ritchie46 ritchie46 merged commit 760ab20 into main Sep 10, 2024
25 checks passed
@ritchie46 ritchie46 deleted the join branch September 10, 2024 12:15
Copy link

codecov bot commented Sep 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.89%. Comparing base (fe04390) to head (c4ea9bc).
Report is 41 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #18658      +/-   ##
==========================================
- Coverage   79.91%   79.89%   -0.03%     
==========================================
  Files        1511     1511              
  Lines      203201   203204       +3     
  Branches     2891     2891              
==========================================
- Hits       162388   162346      -42     
- Misses      40263    40308      +45     
  Partials      550      550              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@c-peters c-peters added the accepted Ready for implementation label Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted Ready for implementation internal An internal refactor or improvement python Related to Python Polars rust Related to Rust Polars
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants