-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
News redesign #1216
News redesign #1216
Conversation
I'm gonna try this out for a while but from first impressions I'm not sold. Feels like a cluttered screen and I also think that those touch targets are to small, I know it's text but it's now also a target for interaction. |
I feel like the cluttering of the screen is more to do with the design, i.e. having the links underlined and being such a vibrant blue. Maybe we can get rid of the blue styling for the username as it's unnecessary when you know you can click the avatar as well. As with the target interaction, I don't feel that's a problem. If you look at Instagram with their hashtags, they have a similar touch target size and they don't seem to have a problem. |
Regarding Instagram that's not one of their main navigation sources. That's content links just like we have in comment bodies. At least that's how I see them. |
Aight, been using it a bit over the last couple of weeks. It's been easier to click the text when it's close together than I expected so that's nice. I'm still not sold on it though. Do some more work on the design and I'll have another look. |
I've removed the underline from the links. I've left the link color as it is just using the accent color which is what is recommended by the material design guidelines (under the section "Secondary color"). Admittedly the color combination between the toolbar and link color isn't great (i.e. primary and accent color), but that is related to #1225, not this PR.
|
In my opinion, I think this is pretty good. |
Thanks @fadils! I'd love to see this get merged as I think it is a step in the right direction for UX. |
Related to #1120.
The avatar and the bold parts of the news item titles are clickable (except from the branch name). The branch name isn't clickable due to the architecture of the app, and such an implementation couldn't be done easily as of yet. This isn't to say that the branch shouldn't be clickable in the future.
Because these things are clickable, long pressing the item to navigate to the user name or repository page is unnecessary so it was removed.