Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

News redesign #1216

Merged
merged 10 commits into from
Mar 28, 2020
Merged

News redesign #1216

merged 10 commits into from
Mar 28, 2020

Conversation

veyndan
Copy link
Collaborator

@veyndan veyndan commented Mar 28, 2018

Related to #1120.

The avatar and the bold parts of the news item titles are clickable (except from the branch name). The branch name isn't clickable due to the architecture of the app, and such an implementation couldn't be done easily as of yet. This isn't to say that the branch shouldn't be clickable in the future.

Because these things are clickable, long pressing the item to navigate to the user name or repository page is unnecessary so it was removed.

Before After
before after

@Meisolsson
Copy link
Contributor

I'm gonna try this out for a while but from first impressions I'm not sold. Feels like a cluttered screen and I also think that those touch targets are to small, I know it's text but it's now also a target for interaction.

@veyndan
Copy link
Collaborator Author

veyndan commented Mar 30, 2018

I feel like the cluttering of the screen is more to do with the design, i.e. having the links underlined and being such a vibrant blue. Maybe we can get rid of the blue styling for the username as it's unnecessary when you know you can click the avatar as well.

As with the target interaction, I don't feel that's a problem. If you look at Instagram with their hashtags, they have a similar touch target size and they don't seem to have a problem.

@Meisolsson
Copy link
Contributor

Regarding Instagram that's not one of their main navigation sources. That's content links just like we have in comment bodies. At least that's how I see them.

@veyndan
Copy link
Collaborator Author

veyndan commented Apr 3, 2018

How about Facebook then? They have a similar style where the title and the comment bodies have content links.

image

@Meisolsson
Copy link
Contributor

Aight, been using it a bit over the last couple of weeks. It's been easier to click the text when it's close together than I expected so that's nice. I'm still not sold on it though. Do some more work on the design and I'll have another look.

@veyndan
Copy link
Collaborator Author

veyndan commented Oct 6, 2019

I've removed the underline from the links. I've left the link color as it is just using the accent color which is what is recommended by the material design guidelines (under the section "Secondary color"). Admittedly the color combination between the toolbar and link color isn't great (i.e. primary and accent color), but that is related to #1225, not this PR.

Initial design Final design
before after

@fadils
Copy link
Member

fadils commented Mar 22, 2020

In my opinion, I think this is pretty good.
And, I'm more than glad to merge it.

@veyndan
Copy link
Collaborator Author

veyndan commented Mar 22, 2020

Thanks @fadils! I'd love to see this get merged as I think it is a step in the right direction for UX.

@Meisolsson Meisolsson merged commit 80833ed into pockethub:master Mar 28, 2020
@veyndan veyndan deleted the news-redesign branch March 29, 2020 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants