Remove usage of Butterknife in Items #1179
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Meisolsson
requested changes
Mar 6, 2018
There was a problem hiding this comment.
Not sure that we still need to extend ViewHolder everywhere. Probably could just skip the createViewHolder and extending ViewHolder unless we need something special at init. Even then we can do that in createViewHolder. Nor sure that we can do this without groupie-kotlin-android-extensions.
|
There are a couple of problems with my implementation, I think I kind of rushed it the first time round. I'll rebase and reimplement it correctly soon. Currently the implementation doesn't even recycle views which is obviously terrible. |
|
I'm just going to close this and make a new PR as most of the code is different. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a partial implementation of #1178 as files that aren't items that use Butterknife have not been edited.