Fix CI for Ruby3.4 #274
Open
Fix CI for Ruby3.4 #274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Old minitest depends on mutex_m gem (before v5.21) without explicit dependency. So it causes dependency errors on CI because the mutex_m gem became the bundled gem since Ruby 3.4. This upgrade minitest to the latest version which does not depends on the mutex_m gem.
Since Ruby 3.4, mutex_m gem becames the bundled gem. So it should be listed on the dependencies list. Note: The latest activesupport now does not depends on it. So it's also okay to upgrade it to the new one.
Since Ruby 3.4, abbrev gem has became the bundled gem. But old rbs gem does not depend on it. This updates rbs gem to v3.4, which depends on abbrev gem explicitly.
|
Now I added an additional commit:
|
Since Ruby 3.4, base64, bigdecimal, and drb gems have became the bundled gem. So they should be listed on the dependencies list. Note: The latest activesupport now depends on them. So it's also okay to upgrade it to the new one.
tk0miya
force-pushed
the
upgrade_minitest
branch
from
ace4687
to
5c94b64
Compare
|
I also added another commit:
|
This was referenced Feb 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our CI with Ruby3.4 has been broken because the mutex_m gem has become the bundled gem since 3.4.
This fixes it via modifying dependencies.
Upgrade minitest to v5.21.1 (latest)
Old minitest depends on mutex_m gem (before v5.21) without explicit
dependency. This upgrade minitest to the latest version which does not depends on
the mutex_m gem.
Add mutex_m to the dependencies of test app
Since Ruby 3.4, mutex_m gem becames the bundled gem. So it should be
listed on the dependencies list.
Note: The latest activesupport now does not depends on it. So it's also
okay to upgrade it to the new one instead of adding.